Skip to content

[Issue] code refactor, php8.x adjustmentts, param types, etc #39875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
m2-assistant bot opened this issue Apr 29, 2025 · 0 comments · May be fixed by #39868
Open
5 tasks

[Issue] code refactor, php8.x adjustmentts, param types, etc #39875

m2-assistant bot opened this issue Apr 29, 2025 · 0 comments · May be fixed by #39868
Labels
Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2025

This issue is automatically created based on existing pull request: #39868: code refactor, php8.x adjustmentts, param types, etc


Description (*)

Just some type fixes + upgrade to php8.x
Needs to be tested and validated properly, as some method properties still do not match in core.

I've made this fix due to this code:

   $items = $this->optionManagement->getItems(
         Product::ENTITY,
         $attributeCode
   );

as it suppose to be an integer, but string has to be passed as the $1 parameter

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Apr 29, 2025 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 29, 2025
@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.x Indicates original Magento version for the Issue report. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Confirmation
Development

Successfully merging a pull request may close this issue.

1 participant