Cannot reindex all invalid on multi-thread indexers with active application lock

[bigbangx]

Preconditions and environment

• 2.4.8-p1
• multiple stores
• env variable MAGE_INDEXER_THREADS_COUNT > 1
• indexer/use_application_lock config : true

Steps to reproduce

1. Invalidate catalog_category_product + catalog_product_category indexers
2. Run bin/magento cron:run --group index to run indexer_reindex_all_invalid

Expected result

It should reindex properly

Actual result

SQLSTATE[42S02]: Base table or view not found: 1146 Table 'magento2.catalog_category_product_index_store1_tmp' doesn't exist, query was: DELETE FROM `catalog_category_product_index_store1_tmp

NB: this error is a bit misleading as the catalog_category_product indexer did reindex properly at first.

Additional information

After some analysis, here is what I found:

When indexation starts, current indexer is locked (using a database lock by default).

When multithreads are starting, parent connections are closed so we are losing the DB locks:
https://github.com/magento/magento2/blob/2.4.8-p1/app/code/Magento/Indexer/Model/ProcessManager.php#L110

When indexation finishes, it checks if indexer is in a "working" state before to set it as "valid"
https://github.com/magento/magento2/blob/2.4.8-p1/app/code/Magento/Indexer/Model/Indexer.php#L471

However, in State::getStatus() function, if status is "working" but NOT locked, then it returns "invalid" instead...
https://github.com/magento/magento2/blob/2.4.8-p1/app/code/Magento/Indexer/Model/Indexer/State.php#L113

So it ends up keeping "working" state and not validating shared indexers (so catalog_product_category starts and the "Base table or view not found" appears).

The commit involved seems to be this one.
d09224a

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @bigbangx. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @bigbangx ,

Thank you for the report and your collaboration.

We attempted to reproduce the reported issue on the 2.4 develop instance, and were able to successfully replicate it. Please find the attached screenshot for reference.

Steps to Reproduce:

• Invalidate the catalog_category_product and catalog_product_category indexers.
• Execute the command:
• bin/magento cron:run --group index
• to trigger indexer_reindex_all_invalid.

We followed the provided preconditions and reproduction steps, and encountered the issue as described. Therefore, we are marking this as "Issue: Confirmed."

Thank you once again!

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-15270 is successfully created for this GitHub issue.