Add Store Code to Urls should be Global

[thomas-kl1]

Description (*)

The Add Store Code to Urls setting in the store web configuration is defined as global.
However in the core, the setting is fetched with the current scope in mind.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Add Store Code to Urls should be Global #40069: Add Store Code to Urls should be Global

[m2-assistant]

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[thomas-kl1]

@magento run all tests

[thomas-kl1]

@magento run all tests

[thomas-kl1]

@magento run Unit Tests, Static Tests, Integration Tests

[thomas-kl1]

@magento run all tests

[engcom-Charlie]

@magento create issue

[thomas-kl1]

@magento run all tests

[thomas-kl1]

@engcom-Charlie Regarding the integration tests failures:

I can't fix the B2B/EE tests, in order to fix them you should replace the getValue par isSetFlag method when looking for the following configs:

• general/single_store_mode/enabled
• web/url/use_store

You should also look for default and not by scope for web/url/use_store.

[thomas-kl1]

@magento run all tests

[thomas-kl1]

@magento run Database Compare

[thomas-kl1]

@magento run Functional Tests CE, Functional Tests B2B

[engcom-Charlie]

@thomas-kl1 thank you for your contribution!

Currently we are looking into priority PRs from Community Dashboard, we will surely pick this PR as per the priority.

Thank you!