fix: encode internal transactions

Author: bmuddha

magicblock-account-cloner/src/lib.rs

@@ -40,7 +40,9 @@ use magicblock_chainlink::{
 };
 use magicblock_committor_service::{BaseIntentCommittor, CommittorService};
 use magicblock_config::config::ChainLinkConfig;
-use magicblock_core::link::transactions::TransactionSchedulerHandle;
+use magicblock_core::link::transactions::{
+    with_encoded, TransactionSchedulerHandle,
+};
 use magicblock_ledger::LatestBlock;
 use magicblock_magic_program_api::{
     args::ScheduleTaskArgs,
@@ -102,7 +104,7 @@ impl ChainlinkCloner {
 
     async fn send_tx(&self, tx: Transaction) -> ClonerResult<Signature> {
         let sig = tx.signatures[0];
-        self.tx_scheduler.execute(tx).await?;
+        self.tx_scheduler.execute(with_encoded(tx)?).await?;
         Ok(sig)
     }
 

magicblock-accounts/src/scheduled_commits_processor.rs

@@ -18,7 +18,9 @@ use magicblock_committor_service::{
     intent_execution_manager::BroadcastedIntentExecutionResult,
     intent_executor::ExecutionOutput, BaseIntentCommittor, CommittorService,
 };
-use magicblock_core::link::transactions::TransactionSchedulerHandle;
+use magicblock_core::link::transactions::{
+    with_encoded, TransactionSchedulerHandle,
+};
 use magicblock_program::{
     magic_scheduled_base_intent::ScheduledIntentBundle,
     register_scheduled_commit_sent, SentCommit, TransactionScheduler,
@@ -199,10 +201,12 @@ impl ScheduledCommitsProcessorImpl {
         let sent_commit =
             Self::build_sent_commit(intent_id, intent_meta, result);
         register_scheduled_commit_sent(sent_commit);
-        match internal_transaction_scheduler
-            .execute(intent_sent_transaction)
-            .await
-        {
+        let Ok(txn) = with_encoded(intent_sent_transaction) else {
+            // Unreachable case, all intent transactions are smaller than 64KB by construction
+            error!("Failed to bincode intent transaction");
+            return;
+        };
+        match internal_transaction_scheduler.execute(txn).await {
             Ok(()) => {
                 debug!("Sent commit signaled")
             }

magicblock-aperture/src/requests/http/mod.rs

@@ -216,7 +216,7 @@ impl HttpDispatcher {
     }
 
     /// Ensures all accounts required for a transaction are present in the `AccountsDb`.
-    #[instrument(skip(self, transaction), fields(signature = %transaction.signature()))]
+    #[instrument(skip_all)]
     async fn ensure_transaction_accounts(
         &self,
         transaction: &SanitizedTransaction,
@@ -231,7 +231,7 @@ impl HttpDispatcher {
         {
             Ok(res) if res.is_ok() => Ok(()),
             Ok(res) => {
-                debug!(result = %res, "Transaction account resolution encountered issues");
+                debug!(%res, "Transaction account resolution encountered issues");
                 Ok(())
             }
             Err(err) => {

magicblock-aperture/src/requests/http/request_airdrop.rs

@@ -1,4 +1,4 @@
-use magicblock_core::link::transactions::SanitizeableTransaction;
+use magicblock_core::link::transactions::with_encoded;
 
 use super::prelude::*;
 
@@ -35,11 +35,13 @@ impl HttpDispatcher {
             lamports,
             self.blocks.get_latest().hash,
         );
-        // we don't need to verify transaction that we just signed
-        let txn = txn.sanitize(false)?;
-        let signature = SerdeSignature(*txn.signature());
+        // we just signed the transaction, it must have a signature
+        let signature =
+            SerdeSignature(txn.signatures.first().cloned().unwrap_or_default());
 
-        self.transactions_scheduler.execute(txn).await?;
+        self.transactions_scheduler
+            .execute(with_encoded(txn)?)
+            .await?;
 
         Ok(ResponsePayload::encode_no_context(&request.id, signature))
     }

magicblock-aperture/src/requests/http/simulate_transaction.rs

@@ -52,7 +52,7 @@ impl HttpDispatcher {
         // Submit the transaction to the scheduler for simulation.
         let result = self
             .transactions_scheduler
-            .simulate(transaction)
+            .simulate(transaction.txn)
             .await
             .map_err(RpcError::transaction_simulation)?;
 

magicblock-api/src/tickers.rs

@@ -9,7 +9,8 @@ use std::{
 use magicblock_accounts::ScheduledCommitsProcessor;
 use magicblock_accounts_db::{traits::AccountsBank, AccountsDb};
 use magicblock_core::link::{
-    blocks::BlockUpdateTx, transactions::TransactionSchedulerHandle,
+    blocks::BlockUpdateTx,
+    transactions::{with_encoded, TransactionSchedulerHandle},
 };
 use magicblock_ledger::{LatestBlock, Ledger};
 use magicblock_magic_program_api as magic_program;
@@ -89,6 +90,11 @@ async fn handle_scheduled_commits<C: ScheduledCommitsProcessor>(
     let tx = InstructionUtils::accept_scheduled_commits(
         latest_block.load().blockhash,
     );
+    let Ok(tx) = with_encoded(tx) else {
+        // Unreachable case, all schedule commit txns are smaller than 64KB by construction
+        error!("Failed to bincode intent transaction");
+        return;
+    };
     if let Err(err) = transaction_scheduler.execute(tx).await {
         error!(error = ?err, "Failed to accept scheduled commits");
         return;