fix: address review comments

Author: bmuddha

config.example.toml

@@ -135,13 +135,10 @@ keypair = "9Vo7TbA5YfC5a33JhAi9Fb41usA6JwecHNRw3f9MzzHAM8hFnXTzL5DcEHwsAFjuUZ8vN
 # - "replica-only": replicate without takeover
 # # specify the pubkey of the primary node, which we are replicating from
 # 
-# [validator.replication-mode.stand-by]
+# [validator.replication-mode.replica-only]
 # url = "nats://0.0.0.0:4222"
 # secret = "SUAXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
 # authority-override = "L12m1UhkJRfHyvLMcVucJwxXeuD728EqVDDwQDxFMNo"
-[validator.replication-mode.stand-by]
-url = "nats://0.0.0.0:4222"
-secret = "SUAXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
 
 [aperture]
 # Network address to bind the main JSON RPC service to.

magicblock-config/src/config/validator.rs

@@ -1,4 +1,5 @@
-// src/config/validator.rs
+use std::fmt;
+
 use serde::{Deserialize, Serialize};
 use solana_keypair::Keypair;
 use solana_pubkey::Pubkey;
@@ -35,14 +36,47 @@ pub enum ReplicationMode {
     ReplicaOnly(ReplicationConfig),
 }
 
-#[derive(Deserialize, Serialize, Debug, Clone)]
+#[derive(Deserialize, Clone)]
 #[serde(rename_all = "kebab-case")]
 pub struct ReplicationConfig {
     pub url: Url,
     pub secret: String,
     pub authority_override: Option<SerdePubkey>,
 }
 
+impl fmt::Debug for ReplicationConfig {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("ReplicationConfig")
+            .field("url", &self.url)
+            .field("secret", &"<redacted>")
+            .field("authority_override", &self.authority_override)
+            .finish()
+    }
+}
+
+impl Serialize for ReplicationConfig {
+    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
+    where
+        S: serde::Serializer,
+    {
+        #[derive(Serialize)]
+        #[serde(rename_all = "kebab-case")]
+        struct Redacted<'a> {
+            url: &'a Url,
+            secret: &'static str,
+            #[serde(skip_serializing_if = "Option::is_none")]
+            authority_override: &'a Option<SerdePubkey>,
+        }
+
+        Redacted {
+            url: &self.url,
+            secret: "<redacted>",
+            authority_override: &self.authority_override,
+        }
+        .serialize(serializer)
+    }
+}
+
 impl Default for ValidatorConfig {
     fn default() -> Self {
         let keypair =

magicblock-config/src/tests.rs

@@ -6,7 +6,7 @@ use solana_keypair::Keypair;
 use tempfile::TempDir;
 
 use crate::{
-    config::{BlockSize, LifecycleMode},
+    config::{validator::ReplicationConfig, BlockSize, LifecycleMode},
     consts::{self, DEFAULT_VALIDATOR_KEYPAIR},
     types::network::{BindAddress, Remote},
     ValidatorParams,
@@ -404,6 +404,10 @@ fn test_example_config_full_coverage() {
         config.validator.keypair.0.to_base58_string(),
         DEFAULT_VALIDATOR_KEYPAIR
     );
+    assert!(matches!(
+        config.validator.replication_mode,
+        crate::config::validator::ReplicationMode::Standalone
+    ));
 
     // ========================================================================
     // 6. Chain Commitment
@@ -710,3 +714,17 @@ fn test_bind_address_toml_deserialize_port_out_of_range_errors() {
         msg
     );
 }
+
+#[test]
+#[parallel]
+fn test_replication_config_debug_redacts_secret() {
+    let cfg = ReplicationConfig {
+        url: "nats://0.0.0.0:4222".parse().unwrap(),
+        secret: "SUASECRET".into(),
+        authority_override: None,
+    };
+
+    let dbg = format!("{cfg:?}");
+    assert!(dbg.contains("<redacted>"));
+    assert!(!dbg.contains("SUASECRET"));
+}