Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

VAMP_WORKFLOW_DRIVER_WORKFLOW_ENVIRONMENT_VARIABLES are not persisted to workflows #6

Open
harmw opened this issue Nov 21, 2016 · 0 comments
Assignees

Comments

@harmw
Copy link

harmw commented Nov 21, 2016

Just noticed I'm missing VAMP_WORKFLOW_DRIVER_WORKFLOW_ENVIRONMENT_VARIABLES when deploying a workflow (through API), while the Vamp instructed workflows do have them (metrics, health).

I would expect these to always be set inside a workflow, like some sort of default. Currently I need to explicitly set them, which is something I don't want to be doing at workflow level (considering they are directed on infra-level)

Snippet from marathon.json (used to deploy Vamp):

"VAMP_WORKFLOW_DRIVER_WORKFLOW_ENVIRONMENT_VARIABLES": "[\"VAMP_KEY_VALUE_STORE_TYPE=consul\",\"VAMP_KEY_VALUE_ROOT_PATH=/vamp/workflows\",\"VAMP_KEY_VALUE_STORE_CONNECTION=consul.blaze:8500\"]",
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants