Remove to_h

Author: DagonWat

lib/mailtrap/contact.rb

@@ -29,10 +29,5 @@ def initialize(options)
     def newly_created?
       @action != 'updated'
     end
-
-    # @return [Hash] The contact attributes as a hash
-    def to_h
-      super.compact
-    end
   end
 end

lib/mailtrap/contact_field.rb

@@ -9,10 +9,5 @@ module Mailtrap
   #   Allowed values: text, integer, float, boolean, date
   # @attr_reader merge_tag [String] Personalize your campaigns by adding a merge tag.
   #   This field will be replaced with unique contact details for each recipient (max 80 characters)
-  ContactField = Struct.new(:id, :name, :data_type, :merge_tag, keyword_init: true) do
-    # @return [Hash] The contact field attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  ContactField = Struct.new(:id, :name, :data_type, :merge_tag, keyword_init: true)
 end

lib/mailtrap/contact_import.rb

@@ -14,10 +14,5 @@ module Mailtrap
     :updated_contacts_count,
     :contacts_over_limit_count,
     keyword_init: true
-  ) do
-    # @return [Hash] The contact attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  )
 end

lib/mailtrap/contact_list.rb

@@ -5,10 +5,5 @@ module Mailtrap
   # @see https://api-docs.mailtrap.io/docs/mailtrap-api-docs/6ec7a37234af2-contact-list
   # @attr_reader id [Integer] The contact list ID
   # @attr_reader name [String] The name of the contact list
-  ContactList = Struct.new(:id, :name, keyword_init: true) do
-    # @return [Hash] The contact list attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  ContactList = Struct.new(:id, :name, keyword_init: true)
 end

lib/mailtrap/email_template.rb

@@ -26,10 +26,5 @@ module Mailtrap
     :created_at,
     :updated_at,
     keyword_init: true
-  ) do
-    # @return [Hash] The template attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  )
 end

lib/mailtrap/inbox.rb

@@ -53,10 +53,5 @@ module Mailtrap
     :max_message_size,
     :permissions,
     keyword_init: true
-  ) do
-    # @return [Hash] The inbox attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  )
 end

lib/mailtrap/project.rb

@@ -16,10 +16,5 @@ module Mailtrap
     :inboxes,
     :permissions,
     keyword_init: true
-  ) do
-    # @return [Hash] The Project attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  )
 end

lib/mailtrap/suppression.rb

@@ -37,10 +37,5 @@ module Mailtrap
     :message_sender_email,
     :message_subject,
     keyword_init: true
-  ) do
-    # @return [Hash] The suppression attributes as a hash
-    def to_h
-      super.compact
-    end
-  end
+  )
 end

spec/mailtrap/contact_spec.rb

@@ -46,11 +46,6 @@
                                  })
     end
 
-    it 'omits nil values' do
-      attributes[:fields] = nil
-      expect(described_class.new(attributes).to_h).not_to have_key(:fields)
-    end
-
     it 'returns without action' do
       expect(contact.to_h).not_to have_key(:action)
     end

spec/mailtrap/project_spec.rb

@@ -32,7 +32,7 @@
     end
 
     it 'creates a project with all attributes' do
-      expect(project).to have_attributes(
+      expect(project).to match_struct(
         id: '123456',
         name: 'My Project',
         share_links: [
@@ -116,24 +116,5 @@
         }
       )
     end
-
-    context 'when some attributes are nil' do
-      let(:project) do
-        described_class.new(
-          id: '123456',
-          name: 'My Project',
-          share_links: nil,
-          inboxes: nil,
-          permissions: nil
-        )
-      end
-
-      it 'returns a hash with only non-nil attributes' do
-        expect(hash).to eq(
-          id: '123456',
-          name: 'My Project'
-        )
-      end
-    end
   end
 end