Skip to content

Commit aa1b71e

Browse files
committed
[components/webvr-recorder] default controller selectors
1 parent 5cc4ef3 commit aa1b71e

File tree

6 files changed

+28
-22
lines changed

6 files changed

+28
-22
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ See documentation for individual components:
2525
- [sun-sky](https://github.com/ngokevin/kframe/tree/master/components/sun-sky/) - Gradient sky with adjustable sun in A-Frame
2626
- [template](https://github.com/ngokevin/kframe/tree/master/components/template/) - Encapsulate groups of entities, use templating engines, and do string interpolations in A-Frame
2727
- [text](https://github.com/ngokevin/kframe/tree/master/components/text/) - Geometry-based text in A-Frame
28-
- [webvr-recorder](https://github.com/ngokevin/kframe/tree/master/components/webvr-recorder/) - WebVR Recorder component for A-Frame.
28+
- [webvr-recorder](https://github.com/ngokevin/kframe/tree/master/components/webvr-recorder/) - A-Frame component to record WebVR pose and events to localStorage or JSON. Then replay them without needing VR.
2929

3030

3131
## Local Installation

components/webvr-recorder/examples/record/index.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,8 @@
1111
<a-sky color="#DADADA"></a-sky>
1212
</a-scene>
1313

14-
<p style="background: #222; color: #FAFAFA; position: fixed; top: 0; margin: 0 auto; padding: 10px; left: 0; right: 0">
15-
Hit `r` to record, `r` to stop recording, and then `r` to replay.
16-
</p>
17-
1814
<!--githubcorner-->
19-
<a href="https://github.com/ngokevin/kframe/tree/master/components/webvr-recorder/examples/basic/" class="github-corner">
15+
<a href="https://github.com/ngokevin/kframe/tree/master/components/webvr-recorder/examples/record/" class="github-corner">
2016
<svg width="80" height="80" viewBox="0 0 250 250" style="fill: #111; color: #EFEFEF; position: fixed; bottom: 0; border: 0; left: 0; transform: rotate(180deg); opacity: 0.8">
2117
<path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path><path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" style="transform-origin: 130px 106px;" class="octo-arm"></path><path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path>
2218
</svg>

components/webvr-recorder/examples/replay/index.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,15 @@
4848
></a-cursor>
4949
</a-camera>
5050
</a-scene>
51+
52+
<!--githubcorner-->
53+
<a href="https://github.com/ngokevin/kframe/tree/master/components/webvr-recorder/examples/replay/" class="github-corner">
54+
<svg width="80" height="80" viewBox="0 0 250 250" style="fill: #111; color: #EFEFEF; position: fixed; bottom: 0; border: 0; left: 0; transform: rotate(180deg); opacity: 0.8">
55+
<path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path><path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" style="transform-origin: 130px 106px;" class="octo-arm"></path><path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path>
56+
</svg>
57+
</a>
58+
<style>.github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}}
59+
</style>
60+
<!--endgithubcorner-->
5161
</body>
5262
</html>

components/webvr-recorder/index.html

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<html>
22
<head>
33
<title>A-Frame webvr-recorder Component</title>
4-
<meta name="description" content="Component to record WebVR pose and events to localStorage or JSON. Then replay them without needing VR."></meta>
4+
<meta name="description" content=""></meta>
55
<style>
66
html {
77
background: #497285;
@@ -61,18 +61,24 @@ <h1><i>webvr-recorder</i> Component for <a href="https://aframe.io">A-Frame</a><
6161

6262
<a class="back" href="https://ngokevin.github.io/kframe/">&larr; K-Frame</a>
6363

64-
<p>WebVR Recorder component for A-Frame.</p>
64+
<p>A-Frame component to record WebVR pose and events to localStorage or JSON. Then replay them without needing VR.</p>
6565

6666
<h2>Examples</h2>
6767

6868
<ul id="examples">
69-
69+
7070
<li>
71-
<a href="examples/basic/" style="background-color: #222; background-image: url()"></a>
72-
<h3>A-Frame WebVR Recorder Component - Basic</h3>
71+
<a href="examples/record/" style="background-color: #222; background-image: url()"></a>
72+
<h3>A-Frame WebVR Recorder Component - Record</h3>
7373
<p></p>
7474
</li>
75-
75+
76+
<li>
77+
<a href="examples/replay/" style="background-color: #222; background-image: url()"></a>
78+
<h3>WebVR Recorder Component - Replay</h3>
79+
<p>An example of playing a pre-recorded recording on a Minecraft example with controller interactions.</p>
80+
</li>
81+
7682
</ul>
7783

7884
<!--githubcorner-->

components/webvr-recorder/index.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ const EVENTS_DECODE = {
2525
*/
2626
AFRAME.registerComponent('webvr-recorder', {
2727
schema: {
28-
controller1: {type: 'string'},
29-
controller2: {type: 'string'},
28+
controller1: {default: '#controller1', type: 'string'},
29+
controller2: {default: '#controller2', type: 'string'},
3030
source: {default: 'webvr-recorder.json'}
3131
},
3232

@@ -240,12 +240,6 @@ function createDownloadLink () {
240240
return link;
241241
}
242242

243-
const re = new RegExp('(\\d+\\.\\d{' + 4 + '})(\\d)');
244-
function truncNum (num) {
245-
var m = num.toString().match(re);
246-
return m ? parseFloat(m[1]) : num.valueOf();
247-
};
248-
249243
function serializeVec3 (vec3) {
250-
return truncNum(vec3.x) + ' ' + truncNum(vec3.y) + ' ' + truncNum(vec3.z);
244+
return vec3.x + ' ' + vec3.y + ' ' + vec3.z;
251245
}

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ <h2>Components</h2>
120120
</li>
121121
<li>
122122
<a href="components/webvr-recorder/">webvr-recorder</a>
123-
<p>WebVR Recorder component for A-Frame.</p>
123+
<p>A-Frame component to record WebVR pose and events to localStorage or JSON. Then replay them without needing VR.</p>
124124
</li>
125125

126126
</ul>

0 commit comments

Comments
 (0)