Workspace labels #3101

Author: YurkinPark

apiserver/plane/api/serializers/issue.py

@@ -310,7 +310,6 @@ class Meta:
         read_only_fields = [
             "id",
             "workspace",
-            "project",
             "created_by",
             "updated_by",
             "created_at",

apiserver/plane/app/serializers/issue.py

@@ -303,11 +303,10 @@ class Meta:
             "name",
             "color",
             "id",
-            "project_id",
             "workspace_id",
             "sort_order",
         ]
-        read_only_fields = ["workspace", "project"]
+        read_only_fields = ["workspace"]
 
 
 class LabelLiteSerializer(BaseSerializer):

apiserver/plane/app/urls/issue.py

@@ -17,7 +17,6 @@
     IssueSubscriberViewSet,
     IssueUserDisplayPropertyEndpoint,
     IssueViewSet,
-    LabelViewSet,
     BulkArchiveIssuesEndpoint,
     DeletedIssuesListViewSet,
     IssuePaginatedViewSet,
@@ -65,23 +64,6 @@
         ),
         name="project-issue",
     ),
-    path(
-        "workspaces/<str:slug>/projects/<uuid:project_id>/issue-labels/",
-        LabelViewSet.as_view({"get": "list", "post": "create"}),
-        name="project-issue-labels",
-    ),
-    path(
-        "workspaces/<str:slug>/projects/<uuid:project_id>/issue-labels/<uuid:pk>/",
-        LabelViewSet.as_view(
-            {
-                "get": "retrieve",
-                "put": "update",
-                "patch": "partial_update",
-                "delete": "destroy",
-            }
-        ),
-        name="project-issue-labels",
-    ),
     path(
         "workspaces/<str:slug>/projects/<uuid:project_id>/bulk-create-labels/",
         BulkCreateIssueLabelsEndpoint.as_view(),

apiserver/plane/app/urls/workspace.py

@@ -17,6 +17,7 @@
     WorkspaceUserProfileEndpoint,
     WorkspaceUserProfileIssuesEndpoint,
     WorkspaceLabelsEndpoint,
+    LabelViewSet,
     WorkspaceProjectMemberEndpoint,
     WorkspaceUserPropertiesEndpoint,
     WorkspaceStatesEndpoint,
@@ -161,6 +162,23 @@
         WorkspaceLabelsEndpoint.as_view(),
         name="workspace-labels",
     ),
+    path(
+        "workspaces/<str:slug>/issue-labels/",
+        LabelViewSet.as_view({"get": "list", "post": "create"}),
+        name="workspace-issue-labels",
+    ),
+    path(
+        "workspaces/<str:slug>/issue-labels/<uuid:pk>/",
+        LabelViewSet.as_view(
+            {
+                "get": "retrieve",
+                "put": "update",
+                "patch": "partial_update",
+                "delete": "destroy",
+            }
+        ),
+        name="workspace-issue-labels",
+    ),
     path(
         "workspaces/<str:slug>/user-properties/",
         WorkspaceUserPropertiesEndpoint.as_view(),

apiserver/plane/app/views/__init__.py

@@ -61,7 +61,7 @@
     WorkspaceJoinEndpoint,
     UserWorkspaceInvitationsViewSet,
 )
-from .workspace.label import WorkspaceLabelsEndpoint
+from .workspace.label import LabelViewSet, WorkspaceLabelsEndpoint
 from .workspace.state import WorkspaceStatesEndpoint
 from .workspace.user import (
     UserLastProjectWithWorkspaceEndpoint,
@@ -132,7 +132,7 @@
 
 from .issue.comment import IssueCommentViewSet, CommentReactionViewSet
 
-from .issue.label import LabelViewSet, BulkCreateIssueLabelsEndpoint
+from .issue.label import BulkCreateIssueLabelsEndpoint
 
 from .issue.link import IssueLinkViewSet
 

apiserver/plane/app/views/issue/label.py

@@ -9,74 +9,13 @@
 from rest_framework import status
 
 # Module imports
-from .. import BaseViewSet, BaseAPIView
+from .. import BaseAPIView
 from plane.app.serializers import LabelSerializer
-from plane.app.permissions import allow_permission, ProjectBasePermission, ROLE
-from plane.db.models import Project, Label
+from plane.app.permissions import allow_permission, WorkSpaceBasePermission, ROLE
+from plane.db.models import Project, Label, Workspace
 from plane.utils.cache import invalidate_cache
 
 
-class LabelViewSet(BaseViewSet):
-    serializer_class = LabelSerializer
-    model = Label
-    permission_classes = [ProjectBasePermission]
-
-    def get_queryset(self):
-        return self.filter_queryset(
-            super()
-            .get_queryset()
-            .filter(workspace__slug=self.kwargs.get("slug"))
-            .filter(project_id=self.kwargs.get("project_id"))
-            .filter(project__project_projectmember__member=self.request.user)
-            .select_related("project")
-            .select_related("workspace")
-            .select_related("parent")
-            .distinct()
-            .order_by("sort_order")
-        )
-
-    @invalidate_cache(
-        path="/api/workspaces/:slug/labels/", url_params=True, user=False, multiple=True
-    )
-    @allow_permission([ROLE.ADMIN])
-    def create(self, request, slug, project_id):
-        try:
-            serializer = LabelSerializer(data=request.data)
-            if serializer.is_valid():
-                serializer.save(project_id=project_id)
-                return Response(serializer.data, status=status.HTTP_201_CREATED)
-            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
-        except IntegrityError:
-            return Response(
-                {"error": "Label with the same name already exists in the project"},
-                status=status.HTTP_400_BAD_REQUEST,
-            )
-
-    @invalidate_cache(path="/api/workspaces/:slug/labels/", url_params=True, user=False)
-    @allow_permission([ROLE.ADMIN])
-    def partial_update(self, request, *args, **kwargs):
-        # Check if the label name is unique within the project
-        if (
-            "name" in request.data
-            and Label.objects.filter(
-                project_id=kwargs["project_id"], name=request.data["name"]
-            )
-            .exclude(pk=kwargs["pk"])
-            .exists()
-        ):
-            return Response(
-                {"error": "Label with the same name already exists in the project"},
-                status=status.HTTP_400_BAD_REQUEST,
-            )
-        # call the parent method to perform the update
-        return super().partial_update(request, *args, **kwargs)
-
-    @invalidate_cache(path="/api/workspaces/:slug/labels/", url_params=True, user=False)
-    @allow_permission([ROLE.ADMIN])
-    def destroy(self, request, *args, **kwargs):
-        return super().destroy(request, *args, **kwargs)
-
-
 class BulkCreateIssueLabelsEndpoint(BaseAPIView):
     @allow_permission([ROLE.ADMIN])
     def post(self, request, slug, project_id):

apiserver/plane/app/views/workspace/label.py

@@ -1,13 +1,18 @@
+# Django imports
+from django.db import IntegrityError
+
 # Third party modules
 from rest_framework import status
 from rest_framework.response import Response
 
 # Module imports
 from plane.app.serializers import LabelSerializer
-from plane.app.views.base import BaseAPIView
+from plane.app.views.base import BaseAPIView, BaseViewSet
 from plane.db.models import Label
-from plane.app.permissions import WorkspaceViewerPermission
-from plane.utils.cache import cache_response
+from plane.utils.cache import cache_response, invalidate_cache
+from plane.app.permissions.workspace import WorkSpaceBasePermission, WorkspaceViewerPermission
+from plane.app.permissions.base import allow_permission, ROLE
+from plane.db.models.workspace import Workspace
 
 
 class WorkspaceLabelsEndpoint(BaseAPIView):
@@ -17,9 +22,66 @@ class WorkspaceLabelsEndpoint(BaseAPIView):
     def get(self, request, slug):
         labels = Label.objects.filter(
             workspace__slug=slug,
-            project__project_projectmember__member=request.user,
-            project__project_projectmember__is_active=True,
-            project__archived_at__isnull=True,
         )
         serializer = LabelSerializer(labels, many=True).data
         return Response(serializer, status=status.HTTP_200_OK)
+
+
+class LabelViewSet(BaseViewSet):
+    serializer_class = LabelSerializer
+    model = Label
+    permission_classes = [WorkSpaceBasePermission]
+
+    def get_queryset(self):
+        return self.filter_queryset(
+            super()
+            .get_queryset()
+            .filter(workspace__slug=self.kwargs.get("slug"))
+            .select_related("workspace")
+            .select_related("parent")
+            .distinct()
+            .order_by("sort_order")
+        )
+
+    @invalidate_cache(
+        path="/api/workspaces/:slug/labels/", url_params=True, user=False, multiple=True
+    )
+    @allow_permission([ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE")
+    def create(self, request, slug):
+        try:
+            ws = Workspace.objects.filter(slug=slug).first()
+            serializer = LabelSerializer(data=request.data)
+            if serializer.is_valid():
+                serializer.save(workspace=ws)
+                return Response(serializer.data, status=status.HTTP_201_CREATED)
+            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
+        except IntegrityError:
+            return Response(
+                {"error": "Label with the same name already exists in the project"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+
+    @invalidate_cache(path="/api/workspaces/:slug/labels/", url_params=True, user=False)
+    @allow_permission([ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE")
+    def partial_update(self, request, *args, **kwargs):
+        # Check if the label name is unique within the project
+        if (
+            "name" in request.data
+            and Label.objects.filter(
+                workspace__slug=kwargs['slug'],
+                name=request.data["name"]
+            )
+            .exclude(pk=kwargs["pk"])
+            .exists()
+        ):
+            return Response(
+                {"error": "Label with the same name already exists in the workspace"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
+        # call the parent method to perform the update
+        return super().partial_update(request, *args, **kwargs)
+
+    @invalidate_cache(path="/api/workspaces/:slug/labels/", url_params=True, user=False)
+    @allow_permission([ROLE.ADMIN], level="WORKSPACE")
+    def destroy(self, request, *args, **kwargs):
+        return super().destroy(request, *args, **kwargs)

apiserver/plane/db/migrations/0093_manage_label_project.py

@@ -0,0 +1,40 @@
+# Generated by Django 4.2.20 on 2025-04-07 07:44
+
+from django.db import migrations, transaction
+
+from plane.db.models import Issue, IssueLabel
+
+def clear_label_project(apps, schema_editor):
+    Label = apps.get_model('db', 'Label')
+    for label in Label.objects.all():
+        existing = Label.objects.filter(name=label.name, project_id=None).first()
+        if existing is None:
+            label.project = None
+            label.save()
+        else:
+            ### Need to move all the current's label issues to existing one.
+            # Process issues in batches to avoid long-running transactions
+            issues_to_move = list(Issue.objects.filter(labels__id=label.id).all())
+            for batch in [issues_to_move[i:i+100] for i in range(0, len(issues_to_move), 100)]:
+                with transaction.atomic():
+                    for issue_to_move in batch:
+                        issue_to_move.labels.remove(label.id)
+                        l_connection = IssueLabel.objects.create(
+                            issue=issue_to_move,
+                            label_id=existing.id,
+                            workspace=issue_to_move.workspace,
+                            project=issue_to_move.project,
+                        )
+                        issue_to_move.save()
+                        l_connection.save()
+            label.delete()
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('db', '0092_alter_deprecateddashboardwidget_unique_together_and_more'),
+    ]
+
+    operations = [
+        migrations.RunPython(clear_label_project, reverse_code=migrations.RunPython.noop),
+    ]

apiserver/plane/db/migrations/0094_remove_label_unique_name_when_project_null_and_not_deleted_and_more.py

@@ -0,0 +1,25 @@
+# Generated by Django 4.2.20 on 2025-04-07 09:39
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('db', '0093_manage_label_project'),
+    ]
+
+    operations = [
+        migrations.RemoveConstraint(
+            model_name='label',
+            name='unique_name_when_project_null_and_not_deleted',
+        ),
+        migrations.RemoveConstraint(
+            model_name='label',
+            name='unique_project_name_when_not_deleted',
+        ),
+        migrations.RemoveField(
+            model_name='label',
+            name='project',
+        ),
+    ]

apiserver/plane/db/models/label.py

@@ -1,10 +1,10 @@
 from django.db import models
 from django.db.models import Q
 
-from .workspace import WorkspaceBaseModel
+from .workspace import BaseModel
 
 
-class Label(WorkspaceBaseModel):
+class Label(BaseModel):
     parent = models.ForeignKey(
         "self",
         on_delete=models.CASCADE,
@@ -18,22 +18,11 @@ class Label(WorkspaceBaseModel):
     sort_order = models.FloatField(default=65535)
     external_source = models.CharField(max_length=255, null=True, blank=True)
     external_id = models.CharField(max_length=255, blank=True, null=True)
+    workspace = models.ForeignKey(
+        "db.Workspace", models.CASCADE, related_name="workspace_%(class)s"
+    )
 
     class Meta:
-        constraints = [
-            # Enforce uniqueness of name when project is NULL and deleted_at is NULL
-            models.UniqueConstraint(
-                fields=["name"],
-                condition=Q(project__isnull=True, deleted_at__isnull=True),
-                name="unique_name_when_project_null_and_not_deleted",
-            ),
-            # Enforce uniqueness of project and name when project is not NULL and deleted_at is NULL
-            models.UniqueConstraint(
-                fields=["project", "name"],
-                condition=Q(project__isnull=False, deleted_at__isnull=True),
-                name="unique_project_name_when_not_deleted",
-            ),
-        ]
         verbose_name = "Label"
         verbose_name_plural = "Labels"
         db_table = "labels"
@@ -42,7 +31,7 @@ class Meta:
     def save(self, *args, **kwargs):
         if self._state.adding:
             # Get the maximum sequence value from the database
-            last_id = Label.objects.filter(project=self.project).aggregate(
+            last_id = Label.objects.filter(workspace=self.workspace).aggregate(
                 largest=models.Max("sort_order")
             )["largest"]
             # if last_id is not None