Additional lints

Author: maneatingape

Cargo.toml

@@ -12,18 +12,19 @@ private_intra_doc_links = "allow"
 
 [lints.rust]
 absolute_paths_not_starting_with_crate = "warn"
+box_pointers = "warn"
 elided_lifetimes_in_paths = "warn"
 explicit_outlives_requirements = "warn"
 ffi_unwind_calls = "warn"
-invalid_reference_casting = "warn"
 keyword_idents = "warn"
 let_underscore_drop = "warn"
 macro_use_extern_crate = "warn"
 meta_variable_misuse = "warn"
 missing_abi = "warn"
 non_ascii_idents = "warn"
-noop_method_call = "warn"
 pointer_structural_match = "warn"
+private_bounds = "warn"
+private_interfaces = "warn"
 single_use_lifetimes = "warn"
 trivial_casts = "warn"
 trivial_numeric_casts = "warn"
@@ -41,34 +42,53 @@ variant_size_differences = "warn"
 
 [lints.clippy]
 absolute_paths = "warn"
+alloc_instead_of_core = "warn"
+allow_attributes = "warn"
+as_underscore = "warn"
+assertions_on_result_states = "warn"
 bool_to_int_with_if = "warn"
 borrow_as_ptr = "warn"
 case_sensitive_file_extension_comparisons = "warn"
 cast_precision_loss = "warn"
 cast_ptr_alignment = "warn"
 checked_conversions = "warn"
+clone_on_ref_ptr = "warn"
 cloned_instead_of_copied = "warn"
 copy_iterator = "warn"
+create_dir = "warn"
+dbg_macro = "warn"
+decimal_literal_representation = "warn"
 default_trait_access = "warn"
+default_union_representation = "warn"
+disallowed_script_idents = "warn"
 doc_link_with_quotes = "warn"
 doc_markdown = "warn"
+empty_drop = "warn"
 empty_enum = "warn"
 empty_structs_with_brackets = "warn"
+error_impl_error = "warn"
+exit = "warn"
+expect_used = "warn"
 expl_impl_clone_on_copy = "warn"
 explicit_deref_methods = "warn"
 explicit_into_iter_loop = "warn"
 explicit_iter_loop = "warn"
+filetype_is_file = "warn"
 filter_map_next = "warn"
 flat_map_option = "warn"
 float_arithmetic = "warn"
 float_cmp = "warn"
+float_cmp_const = "warn"
 fn_params_excessive_bools = "warn"
+fn_to_numeric_cast_any = "warn"
+format_push_string = "warn"
 from_iter_instead_of_collect = "warn"
+get_unwrap = "warn"
 if_not_else = "warn"
 if_then_some_else_none = "warn"
 ignored_unit_patterns = "warn"
-implicit_clone = "warn"
 impl_trait_in_params = "warn"
+implicit_clone = "warn"
 inconsistent_struct_constructor = "warn"
 index_refutable_slice = "warn"
 inefficient_to_string = "warn"
@@ -78,57 +98,89 @@ items_after_statements = "warn"
 iter_not_returning_iterator = "warn"
 large_digit_groups = "warn"
 large_futures = "warn"
+large_include_file = "warn"
 large_stack_arrays = "warn"
 large_types_passed_by_value = "warn"
 linkedlist = "warn"
+lossy_float_literal = "warn"
 macro_use_imports = "warn"
 manual_assert = "warn"
 manual_instant_elapsed = "warn"
 manual_let_else = "warn"
 manual_ok_or = "warn"
 manual_string_new = "warn"
+map_err_ignore = "warn"
 map_unwrap_or = "warn"
 match_bool = "warn"
 match_same_arms = "warn"
 match_wild_err_arm = "warn"
 match_wildcard_for_single_variants = "warn"
 maybe_infinite_iter = "warn"
+mem_forget = "warn"
 mismatching_type_param_order = "warn"
+missing_enforced_import_renames = "warn"
 missing_errors_doc = "warn"
 missing_fields_in_debug = "warn"
+mixed_read_write_in_expression = "warn"
+mod_module_files = "warn"
+multiple_crate_versions = "warn"
+multiple_inherent_impl = "warn"
+multiple_unsafe_ops_per_block = "warn"
 mut_mut = "warn"
+mutex_atomic = "warn"
 needless_bitwise_bool = "warn"
 needless_continue = "warn"
 needless_for_each = "warn"
 needless_pass_by_value = "warn"
 needless_raw_strings = "warn"
+negative_feature_names = "warn"
 no_effect_underscore_binding = "warn"
 no_mangle_with_rust_abi = "warn"
 option_option = "warn"
+panic_in_result_fn = "warn"
+partial_pub_fields = "warn"
+print_stderr = "warn"
 ptr_as_ptr = "warn"
 ptr_cast_constness = "warn"
+pub_use = "warn"
+pub_with_shorthand = "warn"
 range_minus_one = "warn"
+rc_buffer = "warn"
+rc_mutex = "warn"
 redundant_closure_for_method_calls = "warn"
 redundant_else = "warn"
+redundant_feature_names = "warn"
 redundant_type_annotations = "warn"
 ref_binding_to_reference = "warn"
 ref_option_ref = "warn"
 rest_pat_in_fully_bound_structs = "warn"
 return_self_not_must_use = "warn"
 same_functions_in_if_condition = "warn"
 semicolon_if_nothing_returned = "warn"
+semicolon_inside_block = "warn"
+should_panic_without_expect = "warn"
 single_match_else = "warn"
 stable_sort_primitive = "warn"
+string_add = "warn"
 string_add_assign = "warn"
+string_lit_chars_any = "warn"
 struct_excessive_bools = "warn"
+suspicious_xor_used_as_pow = "warn"
+todo = "warn"
 too_many_lines = "warn"
 transmute_ptr_to_ptr = "warn"
 trivially_copy_pass_by_ref = "warn"
+try_err = "warn"
 unchecked_duration_subtraction = "warn"
+undocumented_unsafe_blocks = "warn"
 unicode_not_nfc = "warn"
+unimplemented = "warn"
 uninlined_format_args = "warn"
 unnecessary_box_returns = "warn"
 unnecessary_join = "warn"
+unnecessary_safety_comment = "warn"
+unnecessary_safety_doc = "warn"
+unnecessary_self_imports = "warn"
 unnecessary_wraps = "warn"
 unneeded_field_pattern = "warn"
 unnested_or_patterns = "warn"
@@ -138,4 +190,6 @@ unused_async = "warn"
 unused_self = "warn"
 used_underscore_binding = "warn"
 verbose_bit_mask = "warn"
+verbose_file_reads = "warn"
+wildcard_dependencies = "warn"
 zero_sized_map_values = "warn"

src/util/grid.rs

@@ -35,7 +35,7 @@ pub struct Grid<T> {
 }
 
 impl Grid<u8> {
-    pub fn parse(input: &str) -> Grid<u8> {
+    pub fn parse(input: &str) -> Self {
         let raw: Vec<_> = input.lines().map(str::as_bytes).collect();
         let width = raw[0].len() as i32;
         let height = raw.len() as i32;

src/util/hash.rs

@@ -20,11 +20,11 @@ pub trait FastSetBuilder<T> {
 
 impl<T: Eq + Hash> FastSetBuilder<T> for FastSet<T> {
     fn new() -> Self {
-        HashSet::with_hasher(BuildFxHasher)
+        Self::with_hasher(BuildFxHasher)
     }
 
     fn with_capacity(capacity: usize) -> Self {
-        HashSet::with_capacity_and_hasher(capacity, BuildFxHasher)
+        Self::with_capacity_and_hasher(capacity, BuildFxHasher)
     }
 
     fn build<const N: usize>(array: [T; N]) -> Self {
@@ -46,11 +46,11 @@ pub trait FastMapBuilder<K, V> {
 
 impl<K: Eq + Hash, V> FastMapBuilder<K, V> for FastMap<K, V> {
     fn new() -> Self {
-        HashMap::with_hasher(BuildFxHasher)
+        Self::with_hasher(BuildFxHasher)
     }
 
     fn with_capacity(capacity: usize) -> Self {
-        HashMap::with_capacity_and_hasher(capacity, BuildFxHasher)
+        Self::with_capacity_and_hasher(capacity, BuildFxHasher)
     }
 
     fn build<const N: usize>(array: [(K, V); N]) -> Self {

src/util/point.rs

@@ -62,13 +62,13 @@ impl Point {
 
     #[inline]
     #[must_use]
-    pub fn manhattan(self, other: Point) -> i32 {
+    pub fn manhattan(self, other: Self) -> i32 {
         (self.x - other.x).abs() + (self.y - other.y).abs()
     }
 
     #[inline]
     #[must_use]
-    pub fn signum(self, other: Point) -> Self {
+    pub fn signum(self, other: Self) -> Self {
         Point::new((self.x - other.x).signum(), (self.y - other.y).signum())
     }
 }
@@ -100,7 +100,7 @@ impl Add for Point {
 
     #[inline]
     #[must_use]
-    fn add(self, rhs: Point) -> Self {
+    fn add(self, rhs: Self) -> Self {
         Point::new(self.x + rhs.x, self.y + rhs.y)
     }
 }
@@ -114,7 +114,7 @@ impl AddAssign for Point {
 }
 
 impl Mul<i32> for Point {
-    type Output = Point;
+    type Output = Self;
 
     #[inline]
     #[must_use]
@@ -124,7 +124,7 @@ impl Mul<i32> for Point {
 }
 
 impl Sub for Point {
-    type Output = Point;
+    type Output = Self;
 
     #[inline]
     #[must_use]

src/year2015/day12.rs

@@ -24,7 +24,7 @@
 //! [`iter_signed`]: crate::util::parse
 use crate::util::parse::*;
 
-const RED: &[u8] = "red".as_bytes();
+const RED: &[u8] = b"red";
 
 struct Result {
     next: usize,

src/year2019/day13.rs

@@ -92,6 +92,7 @@ pub fn part2(input: &[i64]) -> i64 {
 #[cfg(feature = "frivolity")]
 fn draw(tiles: &[i64], score: i64, blocks: i64) {
     use crate::util::ansi::*;
+    use std::fmt::Write;
     use std::thread::sleep;
     use std::time::Duration;
 
@@ -100,20 +101,20 @@ fn draw(tiles: &[i64], score: i64, blocks: i64) {
         return;
     }
 
-    let mut s = String::new();
-    s.push_str(&format!("{WHITE}{BOLD}Blocks: {blocks}\tScore: {score} {RESET}\n"));
+    let s = &mut String::new();
+    let _ = writeln!(s, "{WHITE}{BOLD}Blocks: {blocks}\tScore: {score} {RESET}");
 
     for y in 0..20 {
         for x in 0..44 {
-            match tiles[44 * y + x] {
-                0 => s.push(' '),
-                1 if y == 0 => s.push_str(&format!("{GREEN}_{RESET}")),
-                1 => s.push_str(&format!("{GREEN}|{RESET}")),
-                2 => s.push_str(&format!("{BLUE}#{RESET}")),
-                3 => s.push_str(&format!("{WHITE}{BOLD}={RESET}")),
-                4 => s.push_str(&format!("{YELLOW}{BOLD}o{RESET}")),
+            let _ = match tiles[44 * y + x] {
+                0 => write!(s, " "),
+                1 if y == 0 => write!(s, "{GREEN}_{RESET}"),
+                1 => write!(s, "{GREEN}|{RESET}"),
+                2 => write!(s, "{BLUE}#{RESET}"),
+                3 => write!(s, "{WHITE}{BOLD}={RESET}"),
+                4 => write!(s, "{YELLOW}{BOLD}o{RESET}"),
                 _ => unreachable!(),
-            }
+            };
         }
         s.push('\n');
     }

src/year2019/day17.rs

@@ -18,6 +18,7 @@ use super::intcode::*;
 use crate::util::hash::*;
 use crate::util::parse::*;
 use crate::util::point::*;
+use std::fmt::Write;
 use std::ops::ControlFlow;
 
 pub struct Input {
@@ -150,7 +151,7 @@ fn build_path(input: &Input) -> String {
         }
 
         let direction = if direction == left { 'L' } else { 'R' };
-        path.push_str(&format!("{direction},{magnitude},"));
+        let _ = write!(path, "{direction},{magnitude},");
     }
 }
 
@@ -241,7 +242,9 @@ fn visit(mut computer: Computer) -> i64 {
 
         // Highlight the robot's position
         match ascii {
-            '^' | 'v' | '<' | '>' => buffer.push_str(&format!("{BOLD}{YELLOW}{ascii}{RESET}")),
+            '^' | 'v' | '<' | '>' => {
+                let _ = write!(&mut buffer, "{BOLD}{YELLOW}{ascii}{RESET}");
+            }
             _ => buffer.push(ascii),
         }
 

src/year2019/day25.rs

@@ -19,6 +19,7 @@
 use super::intcode::*;
 use crate::util::hash::*;
 use crate::util::parse::*;
+use std::fmt::Write;
 
 pub fn parse(input: &str) -> Vec<i64> {
     input.iter_signed().collect()
@@ -75,9 +76,9 @@ fn pretty_print(output: &str) {
 
     for line in output.lines() {
         if line.starts_with('=') {
-            buffer.push_str(&format!("{BOLD}{WHITE}{line}{RESET}"));
+            let _ = write!(&mut buffer, "{BOLD}{WHITE}{line}{RESET}");
         } else if line.starts_with('-') {
-            buffer.push_str(&format!("{item}{line}{RESET}"));
+            let _ = write!(&mut buffer, "{item}{line}{RESET}");
         } else if line.starts_with("Items here:") {
             item = YELLOW;
             buffer.push_str(line);
@@ -139,7 +140,7 @@ fn play_automatically(input: &[i64]) -> String {
             }
         };
 
-        if let State::Halted = movement_noisy(&mut computer, &last, &mut output) {
+        if matches!(movement_noisy(&mut computer, &last, &mut output), State::Halted) {
             // Keep only the password digits from Santa's response.
             output.retain(|b| b.is_ascii_digit());
             break;

src/year2020/day24.rs

@@ -35,18 +35,14 @@ pub fn parse(input: &str) -> FastSet<Hex> {
                 b'n' => {
                     if b'e' == iter.next().unwrap() {
                         q += 1;
-                        r -= 1;
-                    } else {
-                        r -= 1;
                     }
+                    r -= 1;
                 }
                 b's' => {
-                    if b'e' == iter.next().unwrap() {
-                        r += 1;
-                    } else {
+                    if b'e' != iter.next().unwrap() {
                         q -= 1;
-                        r += 1;
                     }
+                    r += 1;
                 }
                 _ => unreachable!(),
             }