Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom spacing not working in Stack gap prop #6853

Closed
1 of 2 tasks
npearson72 opened this issue Sep 19, 2024 · 4 comments · Fixed by #6855
Closed
1 of 2 tasks

Custom spacing not working in Stack gap prop #6853

npearson72 opened this issue Sep 19, 2024 · 4 comments · Fixed by #6855

Comments

@npearson72
Copy link

npearson72 commented Sep 19, 2024

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.12.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

When adding a custom spacing value (ex: 2xl) in the theme, and then using it as a value in the gap prop of the Stack component, it does not work.

See: https://codesandbox.io/p/sandbox/6h3gvl

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/6h3gvl

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@Kenzo-Wada
Copy link
Contributor

Kenzo-Wada commented Sep 19, 2024

Currently, the specification does not allow custom properties to specify strings that begin with a number.” xxl” and so on, it works fine, so can we ask you to use something like that for now?

P.S. I'll work on fix later, stay tuned:)

@npearson72
Copy link
Author

Currently, the specification does not allow custom properties to specify strings that begin with a number.” xxl” and so on, it works fine, so can we ask you to use something like that for now?

P.S. I'll work on fix later, stay tuned:)

I didn't realize this. It worked in v6, is there a reason for this change. I have some pacing that go up to 5xl, which would make it rather awkward to use xxxxxl.

@Kenzo-Wada
Copy link
Contributor

Kenzo-Wada commented Sep 19, 2024

There are major differences in the architecture to begin with, such as the dependence on emotion in v6 but the use of css modules instead of emotion in v7.

I understand your opinion and I have just created a PR! Can you please support the above until the modified version is released?

@npearson72
Copy link
Author

@Kenzo-Wada yes, absolutely. Thank you for doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants