Retrieve commit payload from message body

dregad · dregad · commit 616b8c89c3d6 · 2019-02-01T01:08:00.000+01:00
Backported from 99ec266. The legacy MantisBT GitHub Service sends the push's payload via eponymous form variable. With the retirement of this service and its replacement by webhooks, the payload is now contained in the body. Fixes #292
diff --git a/SourceGithub/SourceGithub.php b/SourceGithub/SourceGithub.php
@@ -248,9 +248,14 @@ private function api_json_url( $p_repo, $p_url, $p_member = null ) {
 	}
 
 	public function precommit() {
+		# Legacy GitHub Service sends the payload via eponymous form variable
 		$f_payload = gpc_get_string( 'payload', null );
 		if ( is_null( $f_payload ) ) {
-			return;
+			# If empty, retrieve the webhook's payload from the body
+			$f_payload = file_get_contents( 'php://input' );
+			if ( is_null( $f_payload ) ) {
+				return;
+			}
 		}
 
 		if ( false === stripos( $f_payload, 'github.com' ) ) {

Original file line number	Diff line number	Diff line change
`@@ -248,9 +248,14 @@ private function api_json_url( $p_repo, $p_url, $p_member = null ) {`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`public function precommit() {`
	`251`	`+ # Legacy GitHub Service sends the payload via eponymous form variable`
`251`	`252`	`$f_payload = gpc_get_string( 'payload', null );`
`252`	`253`	`if ( is_null( $f_payload ) ) {`
`253`		`- return;`
	`254`	`+ # If empty, retrieve the webhook's payload from the body`
	`255`	`+ $f_payload = file_get_contents( 'php://input' );`
	`256`	`+ if ( is_null( $f_payload ) ) {`
	`257`	`+ return;`
	`258`	`+ }`
`254`	`259`	`}`
`255`	`260`
`256`	`261`	`if ( false === stripos( $f_payload, 'github.com' ) ) {`