Pin stays on the map when results of subsequent queries return

[xinyuluo]

Hi! thanks for the amazing project. I have encountered what I think is a bug, because i think it should be irrelevant to my choice of geocoder (Nominatim).

To reproduce the bug:

1. search for "NUS singapore" (I have a map of singapore), press enter.
2. click on the one that says National University of Singapore from the dropdown list, it zooms in closer to the place;
3. click enter again and the map zooms in even closer;
4. search for the next query "NUH singapore" (do not clear manually clear search box), which has 2 results from the drop down. But when I zoom out the map, the pin for National University of Singapore is still there.

Please see attached screen recording for the reference.

Thank you!

maplibre-geocoder.mp4

[wipfli]

Thanks for reporting. Can you share a stackblitz or something similar?

[xinyuluo]

@wipfli sure. demo is here: https://stackblitz.com/edit/web-platform-fszogw
you will need a maptiler API key to access the basemap. Do you have one?

[wipfli]

Does the one for the MapLibre examples work? get_your_own_OpIi9ZULNHzrESv6T2vL from https://maplibre.org/maplibre-gl-js-docs/example/canvas-source/

[xinyuluo]

Yes it will work. I've just updated stackblitz.

[wipfli]

Cool, I can reproduce the bug you reported. Is there any chance that you can fix this behavior? I would be happy to review a pull request...

[wipfli]

Maybe one has to loop through features. Here is a different example where I made only one marker being highlighted: https://codesandbox.io/s/hopeful-elion-w04kb6

[xinyuluo]

How is the different example related to the bug?
I will try to read code more closely when I have the bandwidth. If i can come up with a fix i will submit a PR

[wipfli]

Maybe it is not really related :S

[wipfli]

Cool, thanks @xinyuluo !

[HarelM]

The code after #118 should be fully typescript, which should help in solving these kind of cases, and if not, refactoring would be a lot easier.
I see that there are promises returning from the geoApi, and there might be a race condition in this case, or a missing marker.remove call.
It should be fairly easy to solve this I hope.
Sorry for the late response...

[HarelM]

Can you reproduce this in the following example page:
https://maplibre.org/maplibre-gl-js/docs/examples/geocoder/
I can't reproduce it...