-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mara configuration interface #5
Comments
Here are my thoughts about the mara config interface: Phase 1A config is done by a For now, I'd say the config should work as of today importing mara packages and patching them (and by that activating them). The logic could be duplicated in mara-cli and mara-app as they are currently the only projects invoking the config. But it is be possible as well to reactivate the mara-config package and placing the logic to import mara_config there. Future ideasFor the future, I personally would like to get rid of all this monkey patching of configs which just return a scalar or dict value. I like the way how superset does it, see superset/config.py. One can still do fancy stuff in the config module, but by default, you just set global variables which are then used in the code. I am not 100% sure about this idea, because it still keeps us in the situation that one has to write the config manually. |
TBD
The text was updated successfully, but these errors were encountered: