Merge pull request #134 from marc-mabe/fix/133/byName-check-ambiguous-values

fixed check of ambiguous values on Enum::byName()

Author: marc-mabe

src/Enum.php

@@ -226,6 +226,11 @@ final public static function byName(string $name)
             throw new InvalidArgumentException("{$const} not defined");
         }
 
+        assert(
+            self::noAmbiguousValues(static::getConstants()),
+            'Ambiguous enumerator values detected for ' . static::class
+        );
+
         return self::$instances[static::class][$name] = new static(\constant($const));
     }
 

tests/MabeEnumTest/EnumTest.php

@@ -339,6 +339,14 @@ public function testDisabledAssertAmbiguousEnumeratorValues()
         EnumAmbiguous::get('unknown');
     }
 
+    public function testByNameAmbiguousEnumeratorValues()
+    {
+        $this->expectException(AssertionError::class);
+        $this->expectExceptionMessage('Ambiguous enumerator values detected for ' . EnumAmbiguous::class);
+
+        EnumAmbiguous::byName('AMBIGUOUS_INT1');
+    }
+
     public function testExtendedEnabledAssertAmbiguousEnumeratorValues()
     {
         $this->expectException(AssertionError::class);