{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":520053695,"defaultBranch":"master","name":"zonemaster-ldns","ownerLogin":"marc-vanderwal","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-08-01T09:54:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/103426270?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1725267420.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"f274b9990a95f702310e0a987a20660b930fc2c0","ref":"refs/heads/feature/#160/part-2","pushedAt":"2024-09-02T08:57:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"rr.t: No need for fc() anymore\n\nRemove a case-insensitive comparison that was done in t/rr.t in order to\nmake unit tests pass on installations where the now removed case\nrandomization feature was enabled.\n\nPreviously, this equality comparison was done case-sensitively, which\nonly worked when this feature was disabled.\n\nWith this change, we can now be almost certain that we don’t do any case\nalterations anymore.","shortMessageHtmlLink":"rr.t: No need for fc() anymore"}},{"before":"e9962414d8874328542bb95d636f7c0f9fcc862e","after":"c11f083f83001aa84236d4b3e4f289a84109a5e1","ref":"refs/heads/feature/#160/part-1","pushedAt":"2024-09-02T08:37:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Ensure unit tests still work with -DRANDOMIZE\n\nCase in point (heh) of how little use the experimental case\nrandomization feature had: one unit tests broke without anyone noticing\nit.\n\nWe can reverse this patch later when the feature is actually removed.","shortMessageHtmlLink":"Ensure unit tests still work with -DRANDOMIZE"}},{"before":null,"after":"e9962414d8874328542bb95d636f7c0f9fcc862e","ref":"refs/heads/feature/#160/part-1","pushedAt":"2024-09-02T08:22:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Ensure unit tests still work with -DRANDOMIZE\n\nCase in point (heh) of how little use the experimental case\nrandomization feature had: one unit tests broke without anyone noticing\nit.\n\nWe can reverse this patch later when the feature is actually removed.","shortMessageHtmlLink":"Ensure unit tests still work with -DRANDOMIZE"}},{"before":null,"after":"146b41de1770583d5ccfd2236a2a04d9d841318f","ref":"refs/heads/issue/#104","pushedAt":"2024-08-29T09:30:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"to_idn(): croak with locale-insensitive message\n\nThe to_idn() function in Zonemaster::LDNS croaks with a plain string if\nan error condition is encountered when converting the supplied string to\nan IDN A-label.\n\nThe test suite provokes one of those error conditions in order to check\nthat a string is indeed thrown. That string is matched against a regular\nexpression.\n\nBut when constructing the string, idn2_strerror() is used, which\nproduces a human-readable explanation of the error but in a\nlocale-dependent way. So the test can succeed on one developer’s machine\nand fail on someone else’s whose system language is different.\n\nHowever, there is little point in replacing these plain strings with\nexception objects, such as a hypothetical Zonemaster::LDNS::Error class\nhierarchy. The only other place in the codebase where to_idn() is called\nis in one file in Zonemaster::Engine, and it doesn’t even care what\nspecific error happened during IDN conversion. Exception objects would\nwork, but they are a pain to build in XS code (even calling out to a\nconstructor function written in Perl is extremely verbose in XS) and\nwould be an extremely overengineered solution to our problem.\n\nFortunately, instead of idn2_strerror(), we can use\nidn2_strerror_name(), which returns locale-independent strings based on\nthe names of the source code’s macros. This solution is very simple,\nmakes the error messages predictable and does not hamper debuggability\nof Zonemaster::LDNS::to_idn() too much.\n\nOf course, should Zonemaster::Engine want to display what specifically\nis wrong with the domain name they entered, we might eventually need\nthe alternative solution.","shortMessageHtmlLink":"to_idn(): croak with locale-insensitive message"}},{"before":"65a7ce9e5d5faba1926b25bb2f173951b55fcd08","after":null,"ref":"refs/heads/bugfix/#149","pushedAt":"2024-08-29T09:25:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":"8b8dd0ba1af6330cdd6dff46df02c0e6984a0761","after":null,"ref":"refs/heads/feature/#155","pushedAt":"2024-08-29T09:25:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":"0c465bad3373d622853a5b2e256cd65a6569a2fb","after":null,"ref":"refs/heads/bugfix/nsec3-covers-method","pushedAt":"2024-08-29T09:23:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":"c27904eaeef6540e1fe0ef32221bd347e390f611","after":null,"ref":"refs/heads/feature/update-perl-version","pushedAt":"2024-08-29T09:22:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":"7dfef87878d98a1e5ef65a01f2f7adb6baaa6e53","after":null,"ref":"refs/heads/bugfix/fix-other-nsec3-methods","pushedAt":"2024-08-29T09:21:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":"b8f44fe73eb40eff7c70c47260e56898fbf8a4f8","after":null,"ref":"refs/heads/bugfix/nsec3-salt-method","pushedAt":"2024-08-29T09:20:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":null,"after":"f64d2f097d5c84b6c13b5062bf82c6f7153e26b0","ref":"refs/heads/bugfix/fix-compiler-warning","pushedAt":"2024-08-29T09:19:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Fix compiler warning in XS code\n\nThe return value of ldns_rr_descript(), of type const\nldns_rr_descriptor*, was assigned to a variable of type\nldns_rr_descriptor*, thus dropping the const qualifier.\n\nMaking said variable a const pointer fixes the warning. And it’s safe to\ndo so too, because no modifications are made through that pointer.","shortMessageHtmlLink":"Fix compiler warning in XS code"}},{"before":"d079e469f44a8a9e0cfbc4bddad25bb114b75c2e","after":"0ea8d219793ab22b130fcc2128b384c2f9b1eeac","ref":"refs/heads/develop","pushedAt":"2024-08-28T09:26:25.000Z","pushType":"push","commitsCount":36,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Merge pull request #193 from zonemaster/master\n\nMerge develop into master (Zonemaster/Zonemaster-LDNS)","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2388814885\" data-permission-text=\"Title is private\" data-url=\"https://github.com/zonemaster/zonemaster-ldns/issues/193\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/zonemaster/zonemaster-ldns/pull/193/hovercard\" href=\"https://github.com/zonemaster/zonemaster-ldns/pull/193\">zonemaster#193</a> from zonemaster/master"}},{"before":null,"after":"c27904eaeef6540e1fe0ef32221bd347e390f611","ref":"refs/heads/feature/update-perl-version","pushedAt":"2023-11-22T09:55:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Travis: test with Perl 5.36, drop 5.14.4\n\nUpdate Perl versions in Travis in order to match the versions we\nofficially support.","shortMessageHtmlLink":"Travis: test with Perl 5.36, drop 5.14.4"}},{"before":"02f9662f064be12941c67b5af7a198d45ff93cac","after":"d079e469f44a8a9e0cfbc4bddad25bb114b75c2e","ref":"refs/heads/develop","pushedAt":"2023-11-22T09:42:04.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Merge pull request #177 from marc-vanderwal/bugfix/nsec3-salt-method\n\nFix crashing induced by Zonemaster::LDNS::RR::NSEC3::salt() method","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2001844213\" data-permission-text=\"Title is private\" data-url=\"https://github.com/zonemaster/zonemaster-ldns/issues/177\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/zonemaster/zonemaster-ldns/pull/177/hovercard\" href=\"https://github.com/zonemaster/zonemaster-ldns/pull/177\">zonemaster#177</a> from marc-vanderwal/bugfix/nsec3-sa…"}},{"before":"f37a23ed6ee5caa532f492b12a1412ba21f788e0","after":"7dfef87878d98a1e5ef65a01f2f7adb6baaa6e53","ref":"refs/heads/bugfix/fix-other-nsec3-methods","pushedAt":"2023-11-21T14:57:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()\n\nThe salt() method in Zonemaster::LDNS::RR::NSEC3PARAM did not work as\ndocumented.\n\nLike two of those accessor methods in NSEC3 I’ve fixed previously, its\nreturn value is a byte string that starts with an extraneous length\nbyte, which isn’t necessary.\n\nThe unit test for this function compares base64-encoded strings. This\nhampers legibility because conversions between hexadecimal strings and\nbase64 strings are not trivial and only a very astute reader would\nnotice that the salt() method also had a similar problem.\n\nAlso improve the documentation and the unit test coverage for that\nmethod.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()"}},{"before":"f37a23ed6ee5caa532f492b12a1412ba21f788e0","after":null,"ref":"refs/heads/bugfix/nsec3-next-owner-method","pushedAt":"2023-11-20T14:34:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"}},{"before":null,"after":"f37a23ed6ee5caa532f492b12a1412ba21f788e0","ref":"refs/heads/bugfix/fix-other-nsec3-methods","pushedAt":"2023-11-20T14:34:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()\n\nThe salt() method in Zonemaster::LDNS::RR::NSEC3PARAM did not work as\ndocumented.\n\nLike two of those accessor methods in NSEC3 I’ve fixed previously, its\nreturn value is a byte string that starts with an extraneous length\nbyte, which isn’t necessary.\n\nThe unit test for this function compares base64-encoded strings. This\nhampers legibility because conversions between hexadecimal strings and\nbase64 strings are not trivial and only a very astute reader would\nnotice that the salt() method also had a similar problem.\n\nAlso improve the documentation and the unit test coverage for that\nmethod.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()"}},{"before":null,"after":"f37a23ed6ee5caa532f492b12a1412ba21f788e0","ref":"refs/heads/bugfix/nsec3-next-owner-method","pushedAt":"2023-11-20T14:33:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()\n\nThe salt() method in Zonemaster::LDNS::RR::NSEC3PARAM did not work as\ndocumented.\n\nLike two of those accessor methods in NSEC3 I’ve fixed previously, its\nreturn value is a byte string that starts with an extraneous length\nbyte, which isn’t necessary.\n\nThe unit test for this function compares base64-encoded strings. This\nhampers legibility because conversions between hexadecimal strings and\nbase64 strings are not trivial and only a very astute reader would\nnotice that the salt() method also had a similar problem.\n\nAlso improve the documentation and the unit test coverage for that\nmethod.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3PARAM: rewrite salt()"}},{"before":"e9f3bff9e90e794bbe240357a216027e365ba9cf","after":"b8f44fe73eb40eff7c70c47260e56898fbf8a4f8","ref":"refs/heads/bugfix/nsec3-salt-method","pushedAt":"2023-11-20T12:54:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Remove newlines from base64-encoded data","shortMessageHtmlLink":"Remove newlines from base64-encoded data"}},{"before":"3fead4b6d007f2f4cb4372dc41e36ed5afd613b6","after":"e9f3bff9e90e794bbe240357a216027e365ba9cf","ref":"refs/heads/bugfix/nsec3-salt-method","pushedAt":"2023-11-20T10:12:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Make Zonemaster::LDNS::RR::NSEC3::salt work\n\nThe salt() method in the Zonemaster::LDNS::RR::NSEC3 module never worked\nand often caused the Perl interpreter to crash. This commit fixes many\nlong-standing issues with the affected code.\n\nFirstly, the root cause of the crash is a double free resulting from the\ninappropriate use of ldns_rdf_deep_free() in the code. The\nldns_nsec3_salt() function returns a pointer to a ldns_rdf structure\nwhich is just a window into the salt field, not a copy of the data. So\ncalling ldns_rdf_deep_free() on that ldns_rdf object causes a part of\nthe original resource record structure to be freed instead. This then\nresults in a double free when the memory for the resource record object\nis deallocated. Calling ldns_rdf_free() instead fixes the crashing.\n\nSecondly, the method doesn’t quite return the salt: it actually returns\na string containing the salt preceded by its length byte. This is\nsurprising, not as documented and unlikely to be useful. This problem is\nfixed by rewriting the entire function so as to return the salt, all the\nsalt and nothing but the salt.\n\nThirdly, the method was also insufficiently covered by unit tests. Tests\nwere added, first to help reproduce the crashes, but also to cover the\ncase of an NSEC3 with non-empty salt.\n\nFinally, the method returns undef if the salt is empty. Not only is that\ndocumented nowhere, but the choice of doing so is questionable. This\ncommit changes the behavior somewhat in this case: if the salt is empty,\nan empty string is returned instead; the method only returns undef if\nthere was a problem accessing the salt field.","shortMessageHtmlLink":"Make Zonemaster::LDNS::RR::NSEC3::salt work"}},{"before":null,"after":"3fead4b6d007f2f4cb4372dc41e36ed5afd613b6","ref":"refs/heads/bugfix/nsec3-salt-method","pushedAt":"2023-11-20T10:09:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Make Zonemaster::LDNS::RR::NSEC3::salt work\n\nThe salt() method in the Zonemaster::LDNS::RR::NSEC3 never worked and\noften caused the Perl interpreter to crash. This commit fixes many\nlong-standing issues with the affected code.\n\nFirstly, the root cause of the crash is a double free resulting from the\ninappropriate use of ldns_rdf_deep_free() in the code. The\nldns_nsec3_salt() function returns a pointer to a ldns_rdf structure\nwhich is just a window into the salt field, not a copy of the data. So\ncalling ldns_rdf_deep_free() on that ldns_rdf object causes a part of\nthe original resource record structure to be freed instead. This then\nresults in a double free when the memory for the resource record object\nis deallocated. Calling ldns_rdf_free() instead fixes the crashing.\n\nSecondly, the method doesn’t quite return the salt: it actually returns\na string containing the salt preceded by its length byte. This is\nsurprising, not as documented and unlikely to be useful. This problem is\nfixed by rewriting the entire function so as to return the salt, all the\nsalt and nothing but the salt.\n\nThirdly, the method was also insufficiently covered by unit tests. Tests\nwere added, first to help reproduce the crashes, but also to cover the\ncase of an NSEC3 with non-empty salt.\n\nFinally, the method returns undef if the salt is empty. Not only is that\ndocumented nowhere, but the choice of doing so is questionable. This\ncommit changes the behavior somewhat in this case: if the salt is empty,\nan empty string is returned instead; the method only returns undef if\nthere was a problem accessing the salt field.","shortMessageHtmlLink":"Make Zonemaster::LDNS::RR::NSEC3::salt work"}},{"before":"786a6e7807009df9e8c606c5e2276ddf1fa24345","after":"0c465bad3373d622853a5b2e256cd65a6569a2fb","ref":"refs/heads/bugfix/nsec3-covers-method","pushedAt":"2023-11-14T10:07:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs\n\nIn Zonemaster::LDNS::RR::NSEC3::covers(), perform a simple sanity check\non resource records before giving them to ldns_nsec_covers_name().\n\nWith ldns version 1.8.3, ldns_nsec_covers_name() crashes if the NSEC3\nresource record has the root domain as owner name or has an empty next\nhashed owner name. Both are cases of invalid NSEC3 resource records that\nshould be tested for before trying to do anything with them.\n\nWhile this is technically an ldns bug, we still need some kind of\nworkaround, especially because Zonemaster::LDNS is linked by default\nagainst a bundled version of ldns.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs"}},{"before":"86612c603b8aa16aaa4775f5a308fb3651dba4d1","after":"786a6e7807009df9e8c606c5e2276ddf1fa24345","ref":"refs/heads/bugfix/nsec3-covers-method","pushedAt":"2023-11-14T08:37:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs\n\nIn Zonemaster::LDNS::RR::NSEC3::covers(), perform a simple sanity check\non resource records before giving them to ldns_nsec_covers_name().\n\nWith ldns version 1.8.3, ldns_nsec_covers_name() crashes if the NSEC3\nresource record has the root domain as owner name or has an empty next\nhashed owner name. Both are cases of invalid NSEC3 resource records that\nshould be tested for before trying to do anything with them.\n\nWhile this is technically an ldns bug, we still need some kind of\nworkaround, especially because Zonemaster::LDNS is linked by default\nagainst a bundled version of ldns.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs"}},{"before":null,"after":"86612c603b8aa16aaa4775f5a308fb3651dba4d1","ref":"refs/heads/bugfix/nsec3-covers-method","pushedAt":"2023-11-13T13:22:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs\n\nIn Zonemaster::LDNS::RR::NSEC3::covers(), perform a simple sanity check\non resource records before giving them to ldns_nsec_covers_name().\n\nWith ldns version 1.8.3, ldns_nsec_covers_name() crashes if the NSEC3\nresource record has the root domain as owner name or has an empty next\nhashed owner name. Both are cases of invalid NSEC3 resource records that\nshould be tested for before trying to do anything with them.\n\nWhile this is technically an ldns bug, we still need some kind of\nworkaround, especially because Zonemaster::LDNS is linked by default\nagainst a bundled version of ldns.","shortMessageHtmlLink":"Zonemaster::LDNS::RR::NSEC3::covers: check RRs"}},{"before":"d0fabf54db2c1f0bcfadcbc7994f0a97894b2210","after":"02f9662f064be12941c67b5af7a198d45ff93cac","ref":"refs/heads/develop","pushedAt":"2023-09-05T08:18:50.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Merge pull request #173 from zonemaster/master\n\nMerge master into develop","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1768271379\" data-permission-text=\"Title is private\" data-url=\"https://github.com/zonemaster/zonemaster-ldns/issues/173\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/zonemaster/zonemaster-ldns/pull/173/hovercard\" href=\"https://github.com/zonemaster/zonemaster-ldns/pull/173\">zonemaster#173</a> from zonemaster/master"}},{"before":"b545a9fc10a70dc5370ea04950d4bb5fbe390f60","after":"d0fabf54db2c1f0bcfadcbc7994f0a97894b2210","ref":"refs/heads/develop","pushedAt":"2023-05-17T07:26:18.137Z","pushType":"push","commitsCount":54,"pusher":{"login":"marc-vanderwal","name":"Marc van der Wal","path":"/marc-vanderwal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/103426270?s=80&v=4"},"commit":{"message":"Merge pull request #135 from mattias-p/110-empty-key\n\nIgnore DNSKEY RRs with incalculable key sizes","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1162799306\" data-permission-text=\"Title is private\" data-url=\"https://github.com/zonemaster/zonemaster-ldns/issues/135\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/zonemaster/zonemaster-ldns/pull/135/hovercard\" href=\"https://github.com/zonemaster/zonemaster-ldns/pull/135\">zonemaster#135</a> from mattias-p/110-empty-key"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMlQwODo1NzowMC4wMDAwMDBazwAAAASqYQ3g","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMlQwODo1NzowMC4wMDAwMDBazwAAAASqYQ3g","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNS0xN1QwNzoyNjoxOC4xMzczNDZazwAAAAMuX1OU"}},"title":"Activity · marc-vanderwal/zonemaster-ldns"}