fix?

mariadb-LeonidFedorov · mariadb-LeonidFedorov · commit 731152feef3b · 2025-08-26T16:50:39.000Z
diff --git a/dbcon/execplan/rewrites.cpp b/dbcon/execplan/rewrites.cpp
@@ -240,7 +240,7 @@ execplan::ParseTree* appendToRoot(execplan::ParseTree* tree, Common& common)
   {
     execplan::ParseTree* andCondition = *treenode;
 
-    // Increment or erase based on container type
+    // Increment or erase based on container type to avoid UB
     if constexpr (is_set<Common>::value)
     {
       treenode = common.erase(treenode);

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ execplan::ParseTree* appendToRoot(execplan::ParseTree* tree, Common& common)`
`240`	`240`	`{`
`241`	`241`	`execplan::ParseTree* andCondition = *treenode;`
`242`	`242`
`243`		`- // Increment or erase based on container type`
	`243`	`+ // Increment or erase based on container type to avoid UB`
`244`	`244`	`if constexpr (is_set<Common>::value)`
`245`	`245`	`{`
`246`	`246`	`treenode = common.erase(treenode);`