feat(configs): extract Inspect config

lib/convenient_service/service/configs.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require_relative "configs/essential"
+
+require_relative "configs/inspect"
 require_relative "configs/standard"
 
 require_relative "configs/aliases"

lib/convenient_service/service/configs/aliases.rb

@@ -4,4 +4,8 @@ module ConvenientService
   module Standard
     Config = ::ConvenientService::Service::Configs::Standard
   end
+
+  module Inspect
+    Config = ::ConvenientService::Service::Configs::Inspect
+  end
 end

lib/convenient_service/service/configs/essential.rb

@@ -29,8 +29,6 @@ module Essential
           concerns do
             use ConvenientService::Plugins::Common::HasInternals::Concern
 
-            use ConvenientService::Plugins::Service::HasInspect::Concern
-
             use ConvenientService::Plugins::Common::HasConstructor::Concern
             use ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern
 
@@ -92,8 +90,6 @@ class self::Result
             concerns do
               use ConvenientService::Plugins::Common::HasInternals::Concern
 
-              use ConvenientService::Plugins::Result::HasInspect::Concern
-
               use ConvenientService::Plugins::Common::HasConstructor::Concern
               use ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern
 
@@ -108,35 +104,21 @@ class self::Result
 
             class self::Data
               include Core
-
-              concerns do
-                use ConvenientService::Plugins::Data::HasInspect::Concern
-              end
             end
 
             class self::Message
               include Core
-
-              concerns do
-                use ConvenientService::Plugins::Message::HasInspect::Concern
-              end
             end
 
             class self::Code
               include Core
-
-              concerns do
-                use ConvenientService::Plugins::Code::HasInspect::Concern
-              end
             end
 
             class self::Status
               include Core
 
               concerns do
                 use ConvenientService::Plugins::Common::HasInternals::Concern
-
-                use ConvenientService::Plugins::Status::HasInspect::Concern
               end
 
               class self::Internals
@@ -168,8 +150,6 @@ class self::Step
               use ConvenientService::Plugins::Step::CanBeCompleted::Concern
 
               use ConvenientService::Plugins::Step::CanBeMethodStep::Concern
-
-              use ConvenientService::Plugins::Step::HasInspect::Concern
             end
 
             ##

lib/convenient_service/service/configs/inspect.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module ConvenientService
+  module Service
+    module Configs
+      module Inspect
+        include Support::Concern
+
+        # rubocop:disable Lint/ConstantDefinitionInBlock
+        included do
+          include Configs::Essential
+
+          concerns do
+            use ConvenientService::Plugins::Service::HasInspect::Concern
+          end
+
+          class self::Result
+            concerns do
+              use ConvenientService::Plugins::Result::HasInspect::Concern
+            end
+
+            class self::Data
+              concerns do
+                use ConvenientService::Plugins::Data::HasInspect::Concern
+              end
+            end
+
+            class self::Message
+              concerns do
+                use ConvenientService::Plugins::Message::HasInspect::Concern
+              end
+            end
+
+            class self::Code
+              concerns do
+                use ConvenientService::Plugins::Code::HasInspect::Concern
+              end
+            end
+
+            class self::Status
+              concerns do
+                use ConvenientService::Plugins::Status::HasInspect::Concern
+              end
+            end
+          end
+
+          class self::Step
+            concerns do
+              use ConvenientService::Plugins::Step::HasInspect::Concern
+            end
+          end
+        end
+        # rubocop:enable Lint/ConstantDefinitionInBlock
+      end
+    end
+  end
+end

lib/convenient_service/service/configs/standard.rb

@@ -23,6 +23,7 @@ module Standard
         # rubocop:disable Lint/ConstantDefinitionInBlock
         included do
           include Configs::Essential
+          include Configs::Inspect
 
           concerns do
             use ConvenientService::Plugins::Common::CachesConstructorArguments::Concern

lib/convenient_service/service/configs/standard/v1.rb

@@ -21,6 +21,7 @@ module V1
           # rubocop:disable Lint/ConstantDefinitionInBlock
           included do
             include Configs::Essential
+            include Configs::Inspect
 
             concerns do
               use ConvenientService::Plugins::Common::CachesConstructorArguments::Concern

spec/lib/convenient_service/examples/dry/gemfile/dry_service/config_spec.rb

@@ -32,7 +32,6 @@
             [
               ConvenientService::Service::Plugins::CanHaveStubbedResults::Concern,
               ConvenientService::Common::Plugins::HasInternals::Concern,
-              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::HasConstructor::Concern,
               ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern,
               ConvenientService::Service::Plugins::HasResult::Concern,
@@ -42,6 +41,7 @@
               ConvenientService::Service::Plugins::CanHaveSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveConnectedSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveFallbacks::Concern,
+              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::CachesConstructorArguments::Concern,
               ConvenientService::Common::Plugins::CanBeCopied::Concern,
               ConvenientService::Service::Plugins::CanRecalculateResult::Concern,
@@ -250,11 +250,11 @@
             let(:concerns) do
               [
                 ConvenientService::Common::Plugins::HasInternals::Concern,
-                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasConstructor::Concern,
                 ConvenientService::Common::Plugins::HasConstructorWithoutInitialize::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanHaveStep::Concern,
+                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasJSendResultDuckShortSyntax::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanRecalculateResult::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasNegatedResult::Concern,

spec/lib/convenient_service/examples/dry/v1/gemfile/dry_service/config_spec.rb

@@ -32,13 +32,13 @@
             [
               ConvenientService::Service::Plugins::CanHaveStubbedResults::Concern,
               ConvenientService::Common::Plugins::HasInternals::Concern,
-              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::HasConstructor::Concern,
               ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern,
               ConvenientService::Service::Plugins::HasResult::Concern,
               ConvenientService::Service::Plugins::HasJSendResult::Concern,
               ConvenientService::Service::Plugins::CanHaveSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveSequentialSteps::Concern,
+              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::CachesConstructorArguments::Concern,
               ConvenientService::Common::Plugins::CanBeCopied::Concern,
               ConvenientService::Service::Plugins::CanRecalculateResult::Concern,
@@ -188,11 +188,11 @@
             let(:concerns) do
               [
                 ConvenientService::Common::Plugins::HasInternals::Concern,
-                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasConstructor::Concern,
                 ConvenientService::Common::Plugins::HasConstructorWithoutInitialize::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanHaveStep::Concern,
+                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasJSendResultDuckShortSyntax::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanRecalculateResult::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanBeFromException::Concern,

spec/lib/convenient_service/examples/rails/gemfile/rails_service/config_spec.rb

@@ -32,7 +32,6 @@
             [
               ConvenientService::Service::Plugins::CanHaveStubbedResults::Concern,
               ConvenientService::Common::Plugins::HasInternals::Concern,
-              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::HasConstructor::Concern,
               ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern,
               ConvenientService::Service::Plugins::HasResult::Concern,
@@ -42,6 +41,7 @@
               ConvenientService::Service::Plugins::CanHaveSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveConnectedSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveFallbacks::Concern,
+              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::CachesConstructorArguments::Concern,
               ConvenientService::Common::Plugins::CanBeCopied::Concern,
               ConvenientService::Service::Plugins::CanRecalculateResult::Concern,
@@ -252,11 +252,11 @@
             let(:concerns) do
               [
                 ConvenientService::Common::Plugins::HasInternals::Concern,
-                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasConstructor::Concern,
                 ConvenientService::Common::Plugins::HasConstructorWithoutInitialize::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanHaveStep::Concern,
+                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasJSendResultDuckShortSyntax::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanRecalculateResult::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasNegatedResult::Concern,

spec/lib/convenient_service/examples/rails/v1/gemfile/rails_service/config_spec.rb

@@ -32,13 +32,13 @@
             [
               ConvenientService::Service::Plugins::CanHaveStubbedResults::Concern,
               ConvenientService::Common::Plugins::HasInternals::Concern,
-              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::HasConstructor::Concern,
               ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern,
               ConvenientService::Service::Plugins::HasResult::Concern,
               ConvenientService::Service::Plugins::HasJSendResult::Concern,
               ConvenientService::Service::Plugins::CanHaveSteps::Concern,
               ConvenientService::Service::Plugins::CanHaveSequentialSteps::Concern,
+              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::CachesConstructorArguments::Concern,
               ConvenientService::Common::Plugins::CanBeCopied::Concern,
               ConvenientService::Service::Plugins::CanRecalculateResult::Concern,
@@ -190,11 +190,11 @@
             let(:concerns) do
               [
                 ConvenientService::Common::Plugins::HasInternals::Concern,
-                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasConstructor::Concern,
                 ConvenientService::Common::Plugins::HasConstructorWithoutInitialize::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanHaveStep::Concern,
+                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasJSendResultDuckShortSyntax::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanRecalculateResult::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::CanBeFromException::Concern,

spec/lib/convenient_service/service/configs/aliases_spec.rb

@@ -7,5 +7,6 @@
 # rubocop:disable RSpec/DescribeClass
 RSpec.describe "convenient_service/service/configs/aliases", type: :standard do
   specify { expect(ConvenientService::Standard::Config).to eq(ConvenientService::Service::Configs::Standard) }
+  specify { expect(ConvenientService::Inspect::Config).to eq(ConvenientService::Service::Configs::Inspect) }
 end
 # rubocop:enable RSpec/DescribeClass

spec/lib/convenient_service/service/configs/amazing_print_inspect_spec.rb

@@ -99,7 +99,7 @@
       # https://github.com/marian13/convenient_service/discussions/43
       #
       it "applies its `included` block only once" do
-        expect(service_class.concerns.to_a.size).to eq(12)
+        expect(service_class.concerns.to_a.size).to eq(11)
       end
     end
   end

spec/lib/convenient_service/service/configs/awesome_print_inspect_spec.rb

@@ -99,7 +99,7 @@
       # https://github.com/marian13/convenient_service/discussions/43
       #
       it "applies its `included` block only once" do
-        expect(service_class.concerns.to_a.size).to eq(12)
+        expect(service_class.concerns.to_a.size).to eq(11)
       end
     end
   end

spec/lib/convenient_service/service/configs/essential_spec.rb

@@ -29,7 +29,6 @@
           let(:concerns) do
             [
               ConvenientService::Common::Plugins::HasInternals::Concern,
-              ConvenientService::Service::Plugins::HasInspect::Concern,
               ConvenientService::Common::Plugins::HasConstructor::Concern,
               ConvenientService::Plugins::Common::HasConstructorWithoutInitialize::Concern,
               ConvenientService::Service::Plugins::HasResult::Concern,
@@ -92,7 +91,6 @@
             let(:concerns) do
               [
                 ConvenientService::Common::Plugins::HasInternals::Concern,
-                ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasInspect::Concern,
                 ConvenientService::Common::Plugins::HasConstructor::Concern,
                 ConvenientService::Common::Plugins::HasConstructorWithoutInitialize::Concern,
                 ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Concern,
@@ -117,54 +115,11 @@
             end
           end
 
-          example_group "service result data" do
-            example_group "concerns" do
-              let(:concerns) do
-                [
-                  ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Entities::Data::Plugins::HasInspect::Concern
-                ]
-              end
-
-              it "sets service result data concerns" do
-                expect(service_class::Result::Data.concerns.to_a).to eq(concerns)
-              end
-            end
-          end
-
-          example_group "service result message" do
-            example_group "concerns" do
-              let(:concerns) do
-                [
-                  ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Entities::Message::Plugins::HasInspect::Concern
-                ]
-              end
-
-              it "sets service result message concerns" do
-                expect(service_class::Result::Message.concerns.to_a).to eq(concerns)
-              end
-            end
-          end
-
-          example_group "service result code" do
-            example_group "concerns" do
-              let(:concerns) do
-                [
-                  ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Entities::Code::Plugins::HasInspect::Concern
-                ]
-              end
-
-              it "sets service result code concerns" do
-                expect(service_class::Result::Code.concerns.to_a).to eq(concerns)
-              end
-            end
-          end
-
           example_group "service result status" do
             example_group "concerns" do
               let(:concerns) do
                 [
-                  ConvenientService::Common::Plugins::HasInternals::Concern,
-                  ConvenientService::Service::Plugins::HasJSendResult::Entities::Result::Plugins::HasJSendStatusAndAttributes::Entities::Status::Plugins::HasInspect::Concern
+                  ConvenientService::Common::Plugins::HasInternals::Concern
                 ]
               end
 
@@ -210,9 +165,7 @@
                 ConvenientService::Common::Plugins::HasInternals::Concern,
                 ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::HasResult::Concern,
                 ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanBeCompleted::Concern,
-                ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanBeMethodStep::Concern,
-
-                ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::HasInspect::Concern
+                ConvenientService::Service::Plugins::CanHaveSteps::Entities::Step::Plugins::CanBeMethodStep::Concern
               ]
             end