Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlantUML direct image integration for codeblock 'plantuml' #131

Closed
volodink opened this issue Apr 5, 2020 · 4 comments
Closed

PlantUML direct image integration for codeblock 'plantuml' #131

volodink opened this issue Apr 5, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@volodink
Copy link

volodink commented Apr 5, 2020

Now i can write this

var s = "JavaScript syntax highlighting";
alert(s);
s = "Python syntax highlighting"
print s

and i got nice hightlighted code.

Using this
height:100%
i can add image to the slide.

Please, consider PlantUML image instead of codeblock highlighting, like

@startuml
a -> b
@enduml
@volodink
Copy link
Author

volodink commented Apr 5, 2020

Slide text:

PlantUML vector chart test

@startuml
a -> b
@enduml

height:100%

Preview image has no image, only highlighted text (--preview gives the same result):
изображение

Turned off MARP preview has transformed image:
изображение

@yhatt
Copy link
Member

yhatt commented Apr 5, 2020

See essentially duplicate issue #116. Community is giving an idea of using markdown-it-plantuml plugin in Marp CLI.


FYI, PlantUML image generation is not implemented to Marp for VS Code and all of our official tools because it requires extra PlantUML server working in the out of JS world. And we also have no plan to support PlantUML in official.

In your VS Code, probably a generated image has provided by PlantUML extension when Marp preview was disabled. Marp will switch render engine to Marp for getting consistent result in all of Marp tools, so the other VS Code extensions for Markdown won't work.

@yhatt yhatt added the duplicate This issue or pull request already exists label Apr 5, 2020
@volodink
Copy link
Author

volodink commented Apr 5, 2020

See essentially duplicate issue #116. Community is giving an idea of using markdown-it-plantuml plugin in Marp CLI.

FYI, PlantUML image generation is not implemented to Marp for VS Code and all of our official tools because it requires extra PlantUML server working in the out of JS world. And we also have no plan to support PlantUML in official.

In your VS Code, probably a generated image has provided by PlantUML extension when Marp preview was disabled. Marp will switch render engine to Marp for getting consistent result in all of Marp tools, so the other VS Code extensions for Markdown won't work.

Yes, seems its done by other markdown processor.
Thanks for explanation. Is there any documentation on how to do #116 (comment)
Where should i place marp.config.js ? maybe FAQ somewhere?

@yhatt
Copy link
Member

yhatt commented Apr 6, 2020

It have to use Marp CLI so see also Marp CLI documentation. Functional engine will be helpful.

NOTE: Marp for VS Code does not support custom Marp CLI config. Our community is working in #123 for VS Code integration.

@yhatt yhatt closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants