Skip to content

8584: Add support for run-end encoded (REE) arrays in arrow-avro #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-augment wants to merge 9 commits into
base: main
Choose a base branch
from
Open

8584: Add support for run-end encoded (REE) arrays in arrow-avro #3

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e371251
Add support for run-end encoded (REE) arrays in arrow-avro
jecsand838 Oct 10, 2025
856fb89
Merge branch 'main' into avro-ree-support
jecsand838 Oct 10, 2025
a820dd2
Merge branch 'main' into avro-ree-support
jecsand838 Oct 11, 2025
cd4a6c2
Merge branch 'main' into avro-ree-support
jecsand838 Oct 13, 2025
57329cc
Update arrow-avro/src/reader/record.rs
jecsand838 Oct 13, 2025
ec4eb36
Update arrow-avro/src/reader/record.rs
jecsand838 Oct 13, 2025
343813f
Update arrow-avro/Cargo.toml
jecsand838 Oct 13, 2025
ade92b8
Address PR Comments
jecsand838 Oct 13, 2025
aed8cf2
Merge branch 'main' into pr-8584-2025-10-24-08-58-57
martin-augment Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arrow-avro/src/writer/encoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
use crate::codec::{AvroDataType, AvroField, Codec};
use crate::schema::{Fingerprint, Nullability, Prefix};
use arrow_array::cast::AsArray;
use arrow_array::types::RunEndIndexType;
Copy link

@coderabbitai coderabbitai bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Remove duplicate RunEndIndexType import—blocking compilation error E0252.

RunEndIndexType is imported on line 23 as a standalone import and again on line 32 within the grouped import block. This creates a duplicate definition in the module namespace, which violates Rust's name uniqueness requirement (E0252) and prevents compilation.

Remove the standalone import on line 23 and retain the grouped import on line 32:

 use crate::codec::{AvroDataType, AvroField, Codec};
 use crate::schema::{Fingerprint, Nullability, Prefix};
 use arrow_array::cast::AsArray;
-use arrow_array::types::RunEndIndexType;
 use arrow_array::types::{
     ArrowPrimitiveType, Date32Type, DurationMicrosecondType, DurationMillisecondType,
     DurationNanosecondType, DurationSecondType, Float32Type, Float64Type, Int16Type, Int32Type,
     Int64Type, IntervalDayTimeType, IntervalMonthDayNanoType, IntervalYearMonthType,
     Time32MillisecondType, Time64MicrosecondType, TimestampMicrosecondType,
     TimestampMillisecondType,
 };
 use arrow_array::types::{
     RunEndIndexType, Time32SecondType, TimestampNanosecondType, TimestampSecondType,
 };

Also applies to: 31-33

🤖 Prompt for AI Agents 
In arrow-avro/src/writer/encoder.rs lines 23 and 31-33, there is a duplicate
import of RunEndIndexType causing Rust E0252; remove the standalone import on
line 23 and keep the grouped import block (line ~32) instead, and scan the
import block to ensure RunEndIndexType appears only once (remove any other
duplicates if present).

use arrow_array::types::{
ArrowPrimitiveType, Date32Type, DurationMicrosecondType, DurationMillisecondType,
DurationNanosecondType, DurationSecondType, Float32Type, Float64Type, Int16Type, Int32Type,
Expand Down
Loading