Disable unused-parameter warnings. (#4)

jverkoey · web-flow · commit 4d04ba737bb1 · 2018-12-20T17:13:30.000-05:00
These warnings cause build failures in release builds when arguments are tested with debug-only assertions.

This will be a breaking change.
diff --git a/strict_warnings_objc_library.bzl b/strict_warnings_objc_library.bzl
@@ -39,6 +39,7 @@ COMMON_COPTS = [
     "-Wunused-variable",
     "-Wunused-volatile-lvalue",
     "-Wused-but-marked-unused",
+    "-Wno-unused-parameter",  # Enabled by -Wall via -Wunused, problems with params used in asserts.
 ]
 
 def strict_warnings_objc_library(

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ COMMON_COPTS = [`
`39`	`39`	`"-Wunused-variable",`
`40`	`40`	`"-Wunused-volatile-lvalue",`
`41`	`41`	`"-Wused-but-marked-unused",`
	`42`	`+ "-Wno-unused-parameter", # Enabled by -Wall via -Wunused, problems with params used in asserts.`
`42`	`43`	`]`
`43`	`44`
`44`	`45`	`def strict_warnings_objc_library(`