Skip to content

Commit 555629e

Browse files
committed
Add error ID arrow:io:ipc:InvalidConstructionType.
1 parent 1f4fa23 commit 555629e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

matlab/src/cpp/arrow/matlab/error/error.h

+1
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,7 @@ static const char* IPC_RECORD_BATCH_WRITE_FAILED =
247247
static const char* IPC_RECORD_BATCH_WRITE_CLOSE_FAILED = "arrow:io:ipc:CloseFailed";
248248
static const char* IPC_RECORD_BATCH_READER_OPEN_FAILED =
249249
"arrow:io:ipc:FailedToOpenRecordBatchReader";
250+
static const char* IPC_RECORD_BATCH_READER_INVALID_CONSTRUCTION_TYPE = "arrow:io:ipc:InvalidConstructionType";
250251
static const char* IPC_RECORD_BATCH_READ_INVALID_INDEX = "arrow:io:ipc:InvalidIndex";
251252
static const char* IPC_RECORD_BATCH_READ_FAILED = "arrow:io:ipc:ReadFailed";
252253
static const char* IPC_TABLE_READ_FAILED = "arrow:io:ipc:TableReadFailed";

matlab/src/cpp/arrow/matlab/io/ipc/proxy/record_batch_stream_reader.cc

+2-3
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,10 @@ libmexclass::proxy::MakeResult RecordBatchStreamReader::make(
8686
const auto type_utf16 = std::u16string(type_mda[0]);
8787
if (type_utf16 == u"Bytes") {
8888
return RecordBatchStreamReader::fromBytes(constructor_arguments);
89-
} else if (type_utf16 == u"Filename") {
89+
} else if (type_utf16 == u"File") {
9090
return RecordBatchStreamReader::fromFile(constructor_arguments);
9191
} else {
92-
// TODO: Create static error id string
93-
return libmexclass::error::Error{"arrow:some:test:id", "Invalid construction type for RecordBatchStreamReader."};
92+
return libmexclass::error::Error{"arrow:io:ipc:InvalidConstructionType", "Invalid construction type for RecordBatchStreamReader."};
9493
}
9594
}
9695

0 commit comments

Comments
 (0)