Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not relying on constrained layout #54

Open
jklymak opened this issue Feb 27, 2019 · 1 comment
Open

Consider not relying on constrained layout #54

jklymak opened this issue Feb 27, 2019 · 1 comment

Comments

@jklymak
Copy link
Member

jklymak commented Feb 27, 2019

Overall this looks fun.

Super happy you are using constrained layout, but suggest you make it optional somehow. There are some times when it'll fail and users will want a way to turn it off.

I'm also not sure about initializing the figure inside of your helper, instead of letting the user pass it (optionally?).

@pganssle
Copy link
Member

Agreed, honestly I kinda thought we already were taking the figure as input.

This issue is related to #47, since I'm not sure if all plotting libraries have the concept of a figure that can be passed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants