ffi(bindings): added is_space to the NotificationRoomInfo
#5907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested changes
Nov 27, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Looks good, please just add a changelog entry about this.
CodSpeed Performance ReportMerging #5907 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5907 +/- ##
==========================================
- Coverage 88.65% 88.65% -0.01%
==========================================
Files 362 362
Lines 104365 104366 +1
Branches 104365 104366 +1
==========================================
- Hits 92530 92529 -1
- Misses 7506 7507 +1
- Partials 4329 4330 +1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@poljar added the changelog |
poljar
requested changes
Nov 27, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Sorry for the trouble, just one minor issue remains.
| ([#5614](https://github.com/matrix-org/matrix-rust-sdk/pull/5614)) | ||
| - Expose `m.federate` in `OtherState::RoomCreate` and `history_visibility` in `OtherState::RoomHistoryVisibility`, allowing clients to know whether a room federates and how its history is shared in the appropriate timeline events. | ||
| - Expose `join_rule` in `OtherState::RoomJoinRules`, allowing clients to know the join rules of a room from the appropriate timeline events. | ||
| - Expose `is_space` in `NotificationRoomInfo`, allowing clients to determine if the room that triggered the notification is a space. |
Contributor
There was a problem hiding this comment.
Please move the entry to the top, new entries are added to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
is_spaceflag to FFI in theNotificationRoomInfo, so that a client can tell through a notification if the room that generated it, is a space or not.