Skip to content

validate_q_factor: dead None-check in range condition #95

Description

@matteospanio

src/torchfx/validation/validators.py:642 checks if min_q is not None or max_q is not None: but min_q defaults to 0.001 and is typed float (line 611), so the condition is always true and the or is dead logic. Tidy the signature/condition so intent (optional bounds) matches the types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions