[MM-537]: Added message to delete webhook after subscription deletion #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kshitij-Katiyar
added
2: Dev Review
raghavaggarwal2308
approved these changes
Dec 4, 2024
wiggin77
approved these changes
Dec 4, 2024
|
I have tested this PR, and there is an issue when deleting subscriptions for a group or a sub-group. When the user clicks on the hyperlink in the message to delete the webhook for a group or a sub-group, they are redirected to a 404 page. |
|
@arush-vashishtha I have fixed the issue, please re test it |
|
Hi @Kshitij-Katiyar, I was retesting this PR, and the issue persists for the sub-groups. Please take a look at this. Screencast.from.06-02-25.03.42.00.PM.IST.webm |
|
@arush-vashishtha Fixed the issue, please re test |
arush-vashishtha
approved these changes
Feb 11, 2025
Kshitij-Katiyar
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added message to delete webhook after subscription deletion
Screenshot
Old
New
Ticket Link
Fixes #537
What to test