Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Role for accessibility #1448

Open
mapengbo0314 opened this issue Apr 22, 2021 · 1 comment
Open

Landmark Role for accessibility #1448

mapengbo0314 opened this issue Apr 22, 2021 · 1 comment

Comments

@mapengbo0314
Copy link

Describe the bug

This is more of an accessibility change, due to accessibility from W3, we should not use "landmark" as roles as it's an abstract role.

Should be a simple one line change for the role. These are the possible subclass roles,
banner
complementary
contentinfo
form
main
navigation
region
search

Minimal reproduction of the problem with instructions

Please see code in repo for calendar-open-day-event and search for "role="landmark"

Screenshots
In our accessibility check we found this issue.
landmark

Versions

  • @angular/core: "^8.2.14"
  • angular-calendar: 0.28.20 (2020-09-13)
  • Browser name and version: Chrome Version 89.0.4389.128 (Official Build) (32-bit)
@matts-bot
Copy link

matts-bot bot commented Apr 22, 2021

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider sponsoring me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant