Skip to content

Proposal: Add an 'areSame' flag.  #52

Open
@dwjohnston

Description

@dwjohnston

basically, each diff type can have an additional flag, areSame, which is set true if the objects are the same.

This functionality can be achieved with this:

const result = detailedDiff(oldItem, newItem); 
const areSame = Object.values(result).reduce((acc, cur) => {
        return acc && Object.values(cur).length === 0
    }, true); 

Activity

anko

anko commented on Nov 30, 2019

@anko
Contributor

Simpler workaround:

const result = detailedDiff(oldItem, newItem); 
const areSame = Object.values(result)
    .every((obj) => Object.keys(obj).length === 0);

I like this idea. The internals could determine this basically for free (just updating a variable in a loop that already exists). Externally, it's more expensive to call Object.values and Object.keys like this on large objects.

Going further: Rather than a boolean areSame, make it an integer total that is 0 if the objects are the same, and +1 for every change, of any type. It's as cheap to calculate (update a variable in a loop that already exists), but gives more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dwjohnston@anko

        Issue actions

          Proposal: Add an 'areSame' flag. · Issue #52 · mattphillips/deep-object-diff