CET Overlay is excessively bright in HDR

[Rool-IO]

Bug

Operating system: Windows 11
Game version: 2.12a (issue present with older versions as well)
CET version: Current (issue is a pre-existing one)
GPU: RTX 3080 FE

Description

CET overlay is drawn excessively bright in HDR.

Expected behaviour

CET overlay to be drawn at paper white brightness level

Reproduction

No idea. It just behaves this way on my install.

CET Overlay being overly bright in HDR.zip

[Rool-IO]

@WSSDude , OptiScaler was having the same issue but Nitec has just fixed it. Here's hoping this is an easy one to put in CET...

[WSSDude]

Seems to be using modified ImGui but, that should be applicable from the shader also I think looking at the change 🤔 And shader is part of the backend so shouldnt need ImGui modifications.

[dragonzkiller]

I did look into this. Sure, it's tonemapped, but only changing the values ImGui actually sends to it's UI pipeline. We could do it at the shader level, but it's still only works on scRGB as it's a linear colorspace. PQ10 (metadata-less HDR10) is non-liner and would require more mapping.

We could take this as an opportunity to pull the shader out of dx12.cpp and implement HDR fixes. Maybe after #993 is finished?

[WSSDude]

Yes, wanted to revisit this overall after #993 along with some other things.

[WSSDude]

Spending most time doing stuff for RED4ext now, but it should simplify a lot of things down the line here.

[WSSDude]

See #982 (comment)