fix: address PR review findings from bot and code review

- Check ~/.claude/pilot/settings.json in _get_forced_claude_version fallback
- Add --cov=pilot.hooks to CI pytest coverage tracking
- Extract duplicated _run_with_input helper to module-level function
- Increase pre-commit tail output from 5 to 20 lines
- Add missing "g r" key assertion in search-removal test

Author: maxritter

.githooks/pre-commit

@@ -14,13 +14,13 @@ INSTALLER_CHANGED=$(git diff --cached --name-only -- 'installer/' | head -1)
 
 if [ -n "$LAUNCHER_CHANGED" ]; then
   echo "[pre-commit] Python source changed — running unit tests..."
-  uv run pytest launcher/tests/ pilot/hooks/tests/ -q --tb=short 2>&1 | tail -5
+  uv run pytest launcher/tests/ pilot/hooks/tests/ -q --tb=short 2>&1 | tail -20
   echo "[pre-commit] Python unit tests passed."
 fi
 
 if [ -n "$INSTALLER_CHANGED" ]; then
   echo "[pre-commit] Installer changed — running installer unit tests..."
-  uv run pytest installer/tests/unit/ -q --tb=short 2>&1 | tail -5
+  uv run pytest installer/tests/unit/ -q --tb=short 2>&1 | tail -20
   echo "[pre-commit] Installer unit tests passed."
 fi
 
@@ -35,12 +35,12 @@ if [ -n "$CONSOLE_CHANGED" ]; then
   fi
 
   echo "[pre-commit] Console source changed — running unit tests..."
-  (cd console && bun test 2>&1) | tail -5
+  (cd console && bun test 2>&1) | tail -20
   echo "[pre-commit] Console unit tests passed."
 
   # --- 3. Console typecheck + build + stage artifacts ---
   echo "[pre-commit] Running typecheck..."
-  (cd console && bun run typecheck 2>&1) | tail -5
+  (cd console && bun run typecheck 2>&1) | tail -20
   echo "[pre-commit] Console typecheck passed."
 
   echo "[pre-commit] Rebuilding console artifacts..."

.github/workflows/release.yml

@@ -134,7 +134,7 @@ jobs:
       - name: Run unit tests with coverage
         run: |
           python3 -m pytest installer/tests/unit/ launcher/tests/unit/ pilot/hooks/tests/ -v \
-            --cov=installer --cov=launcher \
+            --cov=installer --cov=launcher --cov=pilot.hooks \
             --cov-report=term --cov-report=xml
 
   console-tests:

console/tests/ui/search-removal.test.ts

@@ -53,6 +53,7 @@ describe("Search view removal", () => {
     );
     expect(source).not.toContain("Go to Search");
     expect(source).not.toContain("navigate:/search");
+    expect(source).not.toContain('"g r"');
   });
 
   it("Dashboard renders 4 workspace cards including VexorStatus", () => {

installer/steps/dependencies.py

@@ -93,14 +93,20 @@ def install_python_tools() -> bool:
 
 
 def _get_forced_claude_version() -> str | None:
-    """Check ~/.claude/settings.json for FORCE_CLAUDE_VERSION in env section."""
-    settings_path = Path.home() / ".claude" / "settings.json"
-    if settings_path.exists():
-        try:
-            settings = json.loads(settings_path.read_text())
-            return settings.get("env", {}).get("FORCE_CLAUDE_VERSION")
-        except (json.JSONDecodeError, OSError):
-            pass
+    """Check settings files for FORCE_CLAUDE_VERSION in env section."""
+    paths = [
+        Path.home() / ".claude" / "pilot" / "settings.json",
+        Path.home() / ".claude" / "settings.json",
+    ]
+    for settings_path in paths:
+        if settings_path.exists():
+            try:
+                settings = json.loads(settings_path.read_text())
+                version = settings.get("env", {}).get("FORCE_CLAUDE_VERSION")
+                if version:
+                    return version
+            except (json.JSONDecodeError, OSError):
+                pass
     return None
 
 

pilot/hooks/tests/test_tool_redirect.py

@@ -82,101 +82,87 @@ def test_plain_word_not_semantic(self):
         assert is_semantic_pattern("config") is False
 
 
+def _run_with_input(tool_name: str, tool_input: dict | None = None) -> int:
+    """Simulate hook invocation with the given tool name and optional input."""
+    hook_data = {"tool_name": tool_name}
+    if tool_input is not None:
+        hook_data["tool_input"] = tool_input
+    stdin = StringIO(json.dumps(hook_data))
+    with patch("sys.stdin", stdin):
+        return run_tool_redirect()
+
+
 class TestBlockedTools:
     """Tests for tools that should be blocked (exit code 2)."""
 
-    def _run_with_input(self, tool_name: str, tool_input: dict | None = None) -> int:
-        hook_data = {"tool_name": tool_name}
-        if tool_input is not None:
-            hook_data["tool_input"] = tool_input
-        stdin = StringIO(json.dumps(hook_data))
-        with patch("sys.stdin", stdin):
-            return run_tool_redirect()
-
     def test_blocks_web_search(self):
-        result = self._run_with_input("WebSearch", {"query": "python tutorial"})
+        result = _run_with_input("WebSearch", {"query": "python tutorial"})
         assert result == 2
 
     def test_blocks_web_fetch(self):
-        result = self._run_with_input("WebFetch", {"url": "https://example.com"})
+        result = _run_with_input("WebFetch", {"url": "https://example.com"})
         assert result == 2
 
     def test_blocks_enter_plan_mode(self):
-        result = self._run_with_input("EnterPlanMode")
+        result = _run_with_input("EnterPlanMode")
         assert result == 2
 
     def test_blocks_exit_plan_mode(self):
-        result = self._run_with_input("ExitPlanMode")
+        result = _run_with_input("ExitPlanMode")
         assert result == 2
 
 
 class TestHintedTools:
     """Tests for tools that get hints but are allowed (exit code 0)."""
 
-    def _run_with_input(self, tool_name: str, tool_input: dict | None = None) -> int:
-        hook_data = {"tool_name": tool_name}
-        if tool_input is not None:
-            hook_data["tool_input"] = tool_input
-        stdin = StringIO(json.dumps(hook_data))
-        with patch("sys.stdin", stdin):
-            return run_tool_redirect()
-
     def test_hints_grep_with_semantic_pattern(self):
-        result = self._run_with_input("Grep", {"pattern": "where is config loaded"})
+        result = _run_with_input("Grep", {"pattern": "where is config loaded"})
         assert result == 0
 
     def test_no_hint_grep_with_code_pattern(self):
-        result = self._run_with_input("Grep", {"pattern": "def save_config"})
+        result = _run_with_input("Grep", {"pattern": "def save_config"})
         assert result == 0
 
     def test_hints_task_explore(self):
-        result = self._run_with_input("Task", {"subagent_type": "Explore"})
+        result = _run_with_input("Task", {"subagent_type": "Explore"})
         assert result == 0
 
     def test_hints_task_generic_subagent(self):
         """Non-allowed subagent types get a hint."""
-        result = self._run_with_input("Task", {"subagent_type": "general-purpose"})
+        result = _run_with_input("Task", {"subagent_type": "general-purpose"})
         assert result == 0
 
     def test_no_hint_task_spec_reviewer(self):
         """Spec reviewer sub-agents should be allowed without hints."""
-        result = self._run_with_input("Task", {"subagent_type": "pilot:spec-reviewer-compliance"})
+        result = _run_with_input("Task", {"subagent_type": "pilot:spec-reviewer-compliance"})
         assert result == 0
 
     def test_no_hint_task_plan_verifier(self):
-        result = self._run_with_input("Task", {"subagent_type": "pilot:plan-verifier"})
+        result = _run_with_input("Task", {"subagent_type": "pilot:plan-verifier"})
         assert result == 0
 
     def test_no_hint_task_plan_challenger(self):
-        result = self._run_with_input("Task", {"subagent_type": "pilot:plan-challenger"})
+        result = _run_with_input("Task", {"subagent_type": "pilot:plan-challenger"})
         assert result == 0
 
 
 class TestAllowedTools:
     """Tests for tools that should pass through without blocks or hints."""
 
-    def _run_with_input(self, tool_name: str, tool_input: dict | None = None) -> int:
-        hook_data = {"tool_name": tool_name}
-        if tool_input is not None:
-            hook_data["tool_input"] = tool_input
-        stdin = StringIO(json.dumps(hook_data))
-        with patch("sys.stdin", stdin):
-            return run_tool_redirect()
-
     def test_allows_read(self):
-        assert self._run_with_input("Read", {"file_path": "/foo.py"}) == 0
+        assert _run_with_input("Read", {"file_path": "/foo.py"}) == 0
 
     def test_allows_write(self):
-        assert self._run_with_input("Write", {"file_path": "/foo.py"}) == 0
+        assert _run_with_input("Write", {"file_path": "/foo.py"}) == 0
 
     def test_allows_edit(self):
-        assert self._run_with_input("Edit", {"file_path": "/foo.py"}) == 0
+        assert _run_with_input("Edit", {"file_path": "/foo.py"}) == 0
 
     def test_allows_bash(self):
-        assert self._run_with_input("Bash", {"command": "ls"}) == 0
+        assert _run_with_input("Bash", {"command": "ls"}) == 0
 
     def test_allows_task_create(self):
-        assert self._run_with_input("TaskCreate", {"subject": "test"}) == 0
+        assert _run_with_input("TaskCreate", {"subject": "test"}) == 0
 
 
 class TestEdgeCases: