Add test_targets_for_data_frame_parameter and fixing the code

Author: petar-qb

vizro-core/src/vizro/models/_controls/parameter.py

@@ -6,6 +6,7 @@
 from vizro._constants import PARAMETER_ACTION_PREFIX
 from vizro.actions import _parameter
 from vizro.managers import model_manager
+from vizro.managers._model_manager import ModelID
 from vizro.models import Action, VizroBaseModel
 from vizro.models._components.form import Checklist, DatePicker, Dropdown, RadioItems, RangeSlider, Slider
 from vizro.models._models_utils import _log_call
@@ -115,7 +116,8 @@ def _set_actions(self):
                 if filter._dynamic
             ]
 
-            filter_targets = set()
+            existing_target_ids: set[ModelID] = {cast(ModelID, target.split(".")[0]) for target in self.targets}
+            additional_targets: set[ModelID] = set()
 
             # Extend parameter targets with dynamic filters linked to the same figure.
             # Also, include dynamic filter targets to ensure new filter options are correctly calculated
@@ -125,10 +127,11 @@ def _set_actions(self):
                 if figure_arg.startswith("data_frame"):
                     for filter in page_dynamic_filters:
                         if figure_id in filter.targets:
-                            filter_targets.add(filter.id)
-                            filter_targets |= set(filter.targets)
+                            additional_targets.add(cast(ModelID, filter.id))
+                            # Exclude existing targets defined with the "dot" notation to avoid duplicates
+                            additional_targets |= set(filter.targets) - existing_target_ids
 
-            self.targets.extend(list(filter_targets))
+            self.targets.extend(list(additional_targets))
 
             self.selector.actions = [
                 Action(id=f"{PARAMETER_ACTION_PREFIX}_{self.id}", function=_parameter(targets=self.targets))

vizro-core/tests/unit/vizro/models/_controls/test_parameter.py

@@ -2,7 +2,7 @@
 from asserts import assert_component_equal
 
 import vizro.models as vm
-from vizro.managers import model_manager
+from vizro.managers import data_manager, model_manager
 from vizro.models._action._actions_chain import ActionsChain
 from vizro.models._controls.parameter import Parameter
 from vizro.models.types import CapturedCallable
@@ -52,8 +52,8 @@ def test_duplicate_parameter_target_failed_two_params(self):
             Parameter(targets=["scatter_chart.x"], selector=vm.Dropdown(options=["lifeExp", "pop"]))
 
 
-@pytest.mark.usefixtures("managers_one_page_two_graphs")
 class TestPreBuildMethod:
+    @pytest.mark.usefixtures("managers_one_page_two_graphs")
     @pytest.mark.parametrize(
         "test_input, title",
         [
@@ -73,6 +73,7 @@ def test_set_target_and_title_valid(self, test_input, title):
         assert parameter.targets == ["scatter_chart.x"]
         assert parameter.selector.title == title
 
+    @pytest.mark.usefixtures("managers_one_page_two_graphs")
     @pytest.mark.parametrize("test_input", [vm.Slider(), vm.RangeSlider(), vm.DatePicker()])
     def test_numerical_and_temporal_selectors_missing_values(self, test_input):
         parameter = Parameter(targets=["scatter_chart.x"], selector=test_input)
@@ -83,6 +84,7 @@ def test_numerical_and_temporal_selectors_missing_values(self, test_input):
         ):
             parameter.pre_build()
 
+    @pytest.mark.usefixtures("managers_one_page_two_graphs")
     @pytest.mark.parametrize("test_input", [vm.Checklist(), vm.Dropdown(), vm.RadioItems()])
     def test_categorical_selectors_with_missing_options(self, test_input):
         parameter = Parameter(targets=["scatter_chart.x"], selector=test_input)
@@ -93,6 +95,7 @@ def test_categorical_selectors_with_missing_options(self, test_input):
         ):
             parameter.pre_build()
 
+    @pytest.mark.usefixtures("managers_one_page_two_graphs")
     @pytest.mark.parametrize(
         "test_input",
         [
@@ -111,6 +114,35 @@ def test_set_actions(self, test_input):
         assert isinstance(default_action.actions[0].function, CapturedCallable)
         assert default_action.actions[0].id == f"parameter_action_{parameter.id}"
 
+    @pytest.mark.usefixtures("managers_one_page_two_graphs_with_dynamic_data")
+    @pytest.mark.parametrize(
+        "filter_targets, expected_parameter_targets",
+        [
+            ([], {"scatter_chart.data_frame.first_n"}),
+            (["scatter_chart"], {"scatter_chart.data_frame.first_n", "filter_id"}),
+            (["scatter_chart", "box_chart"], {"scatter_chart.data_frame.first_n", "filter_id", "box_chart"}),
+        ],
+    )
+    def test_targets_for_data_frame_parameter(
+        self, filter_targets, expected_parameter_targets, gapminder_dynamic_first_n_last_n_function
+    ):
+        data_manager["gapminder_dynamic_first_n_last_n"] = gapminder_dynamic_first_n_last_n_function
+
+        if filter_targets:
+            dynamic_filter = vm.Filter(id="filter_id", column="pop", targets=filter_targets)
+            model_manager["test_page"].controls.append(dynamic_filter)
+            dynamic_filter.pre_build()
+
+        data_frame_parameter = vm.Parameter(
+            id="test_data_frame_parameter",
+            targets=["scatter_chart.data_frame.first_n"],
+            selector=vm.Slider(id="first_n_parameter", min=1, max=10, step=1),
+        )
+        model_manager["test_page"].controls.append(data_frame_parameter)
+        data_frame_parameter.pre_build()
+
+        assert set(data_frame_parameter.targets) == expected_parameter_targets
+
 
 @pytest.mark.usefixtures("managers_one_page_two_graphs")
 class TestParameterBuild: