Implement _BaseAction and separate Action and AbstractAction

Author: antonymilne

vizro-core/examples/scratch_dev/app.py

@@ -21,8 +21,8 @@
                 color="continent",
                 custom_data=["continent"],
             ),
-            # \actions=[filter_interaction(targets=["scatter_relation_2007"])],
-            actions=[vm.Action(function=filter_interaction(targets=["scatter_relation_2007"]))],  # TODO NOW CHECK
+            actions=[filter_interaction(targets=["scatter_relation_2007"])],
+            # actions=[vm.Action(function=filter_interaction(targets=["scatter_relation_2007"]))],  # TODO NOW CHECK
         ),
         vm.Graph(
             id="scatter_relation_2007",
@@ -64,13 +64,13 @@
 @capture("action")
 # To test legacy=True
 # def my_custom_action(points_data, controls=None):
-def my_custom_action(t, points_data, controls=None):
+def my_custom_action(points_data, controls):
     """Custom action."""
     clicked_point = points_data["points"][0]
     x, y = clicked_point["x"], clicked_point["y"]
     species = clicked_point["customdata"][0]
-    card_1_text = f"Clicked point has sepal length {x}, petal width {y}. {t=}"
-    card_2_text = f"Controls are `{controls}`. {t=}"
+    card_1_text = f"Clicked point has sepal length {x}, petal width {y}."
+    card_2_text = f"Controls are `{controls}`"
     return card_1_text, card_2_text
 
 
@@ -101,12 +101,13 @@ def my_custom_action(t, points_data, controls=None):
             actions=[
                 vm.Action(
                     # function=my_custom_action,
-                    # inputs=["scatter_chart.clickData"],
+                    # ("scatter_chart.clickData"),
                     # TODO NOW CHECK: make sure user-specified argument continues to take precedence
                     # function=my_custom_action("scatter_chart.clickData", controls="my_card_1.children"),
                     # TODO NOW CHECK: test to make sure this old way continues to work
-                    function=my_custom_action(t=4),
-                    inputs=["scatter_chart.clickData"],
+                    # function=my_custom_action(),
+                    # function=my_custom_action(t=4),
+                    # inputs=["scatter_chart.clickData"],
                     outputs=["my_card_1.children", "my_card_2.children"],
                 ),
             ],

vizro-core/src/vizro/actions/export_data_action.py

@@ -8,8 +8,6 @@
 from vizro.managers import model_manager
 from vizro.managers._model_manager import ModelID
 
-"""Pre-defined action function "export_data" to be reused in `action` parameter of VizroBaseModels."""
-
 from collections.abc import Iterable
 from typing import Literal, cast
 
@@ -27,7 +25,7 @@ class export_data(AbstractAction):
     ] = []  # TODO NOW: think about whether should in future rename this so it doesn't inconsistently use targets? May be ok now that targets doesn't yet have special role.
     file_format: Literal["csv", "xlsx"] = "csv"
 
-    # TODO NOW: continue testing this and eventually remove.
+    # TODO NOW CHECK: continue testing this and eventually remove.
     runtime_arg: str
 
     def function(
@@ -56,8 +54,6 @@ def function(
         # will change in future once the structure of controls has been worked out and we know how to pass ids through.
         # See https://github.com/mckinsey/vizro/pull/880
         # TODO NOW: move the setting of targets to validator. Reused in outputs and components
-        # TODO NOW: test this runtime argument
-        # print(f"{runtime_arg=}")
         targets = self.targets or [
             output["id"]["target_id"]
             for output in ctx.outputs_list
@@ -84,12 +80,12 @@ def function(
 
         return outputs
 
-    @property
     # TODO NOW: think about if this is best way.
     # overrides _outputs_ not outputs
     # could convert to string ids and use outputs
     # leave like this because hopefully will have single download component in future anyway with a reserved id
-    def _outputs_(self) -> dict[str, Output]:
+    @property
+    def _transformed_outputs(self) -> dict[str, Output]:
         # TODO NOW: comment
         targets = self.targets or [
             model.id
@@ -107,7 +103,11 @@ def _outputs_(self) -> dict[str, Output]:
             for target in targets
         }
 
+    # TODO NOW: just needed due to abstractmethod
     @property
+    def outputs(self):
+        pass
+
     # TODO NOW: put these thoughts somewhere
     # For multiple files could use single dcc.Download but zip file.
     # Will need some way to add new components on the fly for other actions though.
@@ -116,7 +116,8 @@ def _outputs_(self) -> dict[str, Output]:
     # Petar qn: what other actions would require new components on page?
     # Note name clash with "components" and current model_manager __get_model_children that looks for "components"
     # for Page.components. Hence call dash_components, which is probably better name anyway.
-    def dash_components(self) -> list[dcc.Download]:
+    @property
+    def _dash_components(self) -> list[dcc.Download]:
         """Creates dcc.Downloads for target components of the `export_data` action."""
         targets = self.targets or [
             model.id