Skip to content

Commit 7fc2246

Browse files
committed
Last fixes
1 parent 39be3a1 commit 7fc2246

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

vizro-core/src/vizro/models/_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ class VizroBaseModel(BaseModel):
214214
str,
215215
AfterValidator(set_id),
216216
Field(
217-
default="", # TODO[MS]: potentially change to None
217+
default="",
218218
description="ID to identify model. Must be unique throughout the whole dashboard."
219219
"When no ID is chosen, ID will be automatically generated.",
220220
validate_default=True,

vizro-core/src/vizro/models/_dashboard.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def _all_hidden(components: list[Component]):
4444
return all(
4545
component is None
4646
or getattr(component, "hidden", False)
47-
or "d-none" in getattr(component, "className", "d-inline") # TODO: this may be important
47+
or "d-none" in getattr(component, "className", "d-inline")
4848
for component in components
4949
)
5050

0 commit comments

Comments
 (0)