Commit f07e689
authored
fix(compat.glfw, compat.mimalloc, compat.vulkan): Windows links as runtime.libraries, not GNU ldflags (#402)
All three declared their Windows system libraries as `ldflags` in the GNU
spelling. `ldflags` reach the linker verbatim, and link.exe does not reject
`-lgdi32` -- it drops it:
LNK4044: unrecognized option '/lgdi32'; ignored
and carries on, so the first sign is a consumer's link ending in unresolved
externals (235 of them on xrgui). Every MSVC consumer has been re-declaring
these three packages' libraries in its own manifest to compensate.
`runtime.libraries` and `runtime.link_library_dirs` are the dialect-neutral
half of a link line: rendered as gdi32.lib / /LIBPATH: for MSVC and -lgdi32 /
-L for GNU. compat.libgbm already uses `link_library_dirs` in this form.
compat.glfw gdi32
compat.mimalloc psapi shell32 user32 advapi32 bcrypt
compat.vulkan vulkan-1, search dir lib/
Linux and macOS sections are unchanged. Payloads are unchanged, so no version
moves. Consumer: Sunrisepeak/xrgui#8, which deletes its copies.1 parent e07b3d7 commit f07e689
3 files changed
Lines changed: 26 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
165 | 173 | | |
166 | 174 | | |
167 | 175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
107 | 115 | | |
108 | 116 | | |
109 | 117 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
442 | 441 | | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
443 | 450 | | |
444 | 451 | | |
445 | 452 | | |
| |||
0 commit comments