Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode extension fails with new refactoring "move to file" #420

Open
4 tasks done
SantoJambit opened this issue Mar 21, 2024 · 4 comments
Open
4 tasks done

vscode extension fails with new refactoring "move to file" #420

SantoJambit opened this issue Mar 21, 2024 · 4 comments
Labels
🗄 area/interface This affects the public interface 🌊 blocked/upstream This cannot progress before something external happens first 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Comments

@SantoJambit
Copy link

Initial checklist

Affected packages and versions

1.8.2

Link to runnable example

No response

Steps to reproduce

  • Install the extension
  • create an .mdx file and two .ts files
  • try to move something from one ts file to another via the new refactoring "move to file"
  • observe the error shown by vscode

Expected behavior

vscode should show the file selection popup (it does without the extension installed)

Actual behavior

An error pops up:

TypeScript Server Error (5.4.2)
Debug Failure. File /.../file.mdx has unknown extension.
Error: Debug Failure. File /.../file.mdx has unknown extension.
at extensionFromPath (/.../node_modules/typescript/lib/tsserver.js:21381:39)
at /.../node_modules/typescript/lib/tsserver.js:147260:33
at mapDefined (/.../node_modules/typescript/lib/tsserver.js:2680:22)
at Proxy.getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:147259:19)
at IpcIOSession.getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:187171:41)
at getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:185370:43)
at /.../node_modules/typescript/lib/tsserver.js:187524:69
at IpcIOSession.executeWithRequestId (/.../node_modules/typescript/lib/tsserver.js:187516:14)
at IpcIOSession.executeCommand (/.../node_modules/typescript/lib/tsserver.js:187524:29)
at IpcIOSession.onMessage (/.../node_modules/typescript/lib/tsserver.js:187566:51)
at process. (/.../node_modules/typescript/lib/tsserver.js:189175:14)
at process.emit (node:events:514:28)
at emit (node:internal/child_process:937:14)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

Runtime

Other (please specify in steps to reproduce)

Package manager

Other (please specify in steps to reproduce)

OS

Linux

Build and bundle tools

Other (please specify in steps to reproduce)

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 21, 2024
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Mar 21, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Mar 21, 2024
Copy link
Contributor

Hi! This was marked as ready to be worked on! Note that while this is ready to be worked on, nothing is said about priority: it may take a while for this to be solved.

Is this something you can and want to work on?

Team: please use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this. If this is first-timers friendly, add good first issue and if this could use help, add help wanted.

@johnsoncodehk
Copy link
Contributor

This is also a debug error encountered by @Princesseuh in astro language tools. It needs to be solved upstream. I will open an issue to TypeScript.

@Princesseuh
Copy link

Princesseuh commented Mar 21, 2024

Yep, here's the corresponding issue withastro/language-tools#812 in Astro

@remcohaszing remcohaszing added the 🌊 blocked/upstream This cannot progress before something external happens first label Mar 23, 2024
@louisgv
Copy link

louisgv commented Aug 23, 2024

This is somewhat relevant to #413 - downgrading to 1.7.3 worked

See my extension list - I do not have astro tool:

#413 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 🌊 blocked/upstream This cannot progress before something external happens first 👍 phase/yes Post is accepted and can be worked on 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

No branches or pull requests

5 participants