Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handler for spider #258

Open
gilles-yvetot opened this issue Jan 25, 2017 · 3 comments
Open

Error Handler for spider #258

gilles-yvetot opened this issue Jan 25, 2017 · 3 comments

Comments

@gilles-yvetot
Copy link

Hello @Yomguithereal,

I have defined an error handler in my ajax spider, it is correctly triggered when I have a 400 request but I would love to be able to call the done() methods from the error handler and I see that the error object returned contains methods such as done(), complete() but I cannot make it work.

The use case would be when you query an API, and you reach a threshold or there is no more data (404), you want to be able to complete the script and save the previously accumulated data.

@gilles-yvetot
Copy link
Author

Forgot to mention: awesome job !

@Yomguithereal
Copy link
Member

Thanks @gilles-yvetot. There is already similar issues on the subject if I recall correclty. I completely understand the appeal of such feature but unfortunately I don't have much time lately to address this issue. I would gladly accept a PR about error handling for the ajaxSpider however.

@gilles-yvetot
Copy link
Author

gilles-yvetot commented Jan 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants