Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SETTINGS] Allow editing corpus settings when no webentity in corpus yet #229

Closed
8 tasks done
boogheta opened this issue Oct 4, 2017 · 0 comments
Closed
8 tasks done

[SETTINGS] Allow editing corpus settings when no webentity in corpus yet #229

boogheta opened this issue Oct 4, 2017 · 0 comments
Labels
feature web interface
Milestone
Frontend advanced

Comments

@boogheta
Copy link
Member

boogheta commented Oct 4, 2017 •
edited
Loading

The SETTINGS page should allow to edit some of its fields on the condition that the corpus has no webentity and no crawl yet:

  • defaultStartpagesMode (with checkboxes for "homepage", "startpages", "pages-5", "prefixes"
  • proxy host & port
  • defaultCreationRule (with a radio input between "domain", "subdomain", "page")
  • follow_redirects domains (remove or add some)
  • better handle error cases (cf 18bfc59#r35430034 )
  • do not cancel when invalid checks (cf 18bfc59#r35429981 )
  • startpagesmode: allow to change the N of pages-N
  • specific creation rules ?
    - [ ] cautious crawl + domains (when JS crawling finished cf JS Crawling via chrome headless #288)

see doc for details on option values https://github.com/medialab/hyphe/blob/master/doc/config.md
@boogheta boogheta added this to the Frontend advanced milestone May 29, 2019
@boogheta boogheta changed the title [Front] Allow editing corpus settings when no webentity in corpus yet [SETTINGS] Allow editing corpus settings when no webentity in corpus yet Sep 27, 2019
2LaMa added a commit that referenced this issue Oct 7, 2019
@2LaMa
Adding interface to allow editing settings of a corpus while the corp…
856c4cd 
…us is still empty. Buttons will be plugged soon. #229
2LaMa added a commit that referenced this issue Oct 9, 2019
@2LaMa
Plugging edit settings interface for an empty corpus. #229
18bfc59
2LaMa added a commit that referenced this issue Oct 10, 2019
@2LaMa
Changing some bug-bringer ng-if to ng-show, improving settings page a…
fb8fda8 
…nd disabling buttons when api requests. Also, creating a json object to communicate options so that there is no overwriting anymore. #229
2LaMa added a commit that referenced this issue Oct 11, 2019
@2LaMa
Now buttons are disabled while an api is already performing on the co…
d971265 
…rpus. Adding a spinner to show it. #229
2LaMa added a commit that referenced this issue Oct 18, 2019
@2LaMa
Hiding the two Cautious sections that are not used for the moment and…
87a79b0 
… adding the possibility to change the number of pages as startpages. #229
2LaMa added a commit that referenced this issue Oct 18, 2019
@2LaMa
Fixing minor stuff, setting a constant MAXPAGES... #229
eafa1ac
2LaMa added a commit that referenced this issue Oct 24, 2019
@2LaMa
Fixing that proxy section disappeared when proxy is set to empty. #229
e0ec9e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature web interface
Projects
None yet
Milestone
Frontend advanced
Development

No branches or pull requests
2 participants
@jacomyma @boogheta