Skip to content

factor "shutdown" flow into one place #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
meejah opened this issue Feb 12, 2025 · 1 comment
Open

factor "shutdown" flow into one place #52

meejah opened this issue Feb 12, 2025 · 1 comment

Comments

@meejah
Copy link
Owner

meejah commented Feb 12, 2025

If the "nice shutdown" flow actually works well, factor it into FowlWormhole.close_wormhole (or similar). If it doesn't (or if it goes in magic-wormhole itself) then delete it.
@meejah
Copy link
Owner Author

meejah commented Feb 12, 2025

Also, the "closing -> closed" dance isn't fully correct: the side that didn't initiate the closing flow never is satisfied and keeps waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meejah