-
Notifications
You must be signed in to change notification settings - Fork 93
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Also, if you are a maintainer, please add any clarification and instructions about this issue.
Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.
Related to meilisearch/integration-guides#267
Ensure this SDK follows the following guidelines:
- All the errors > 400 without message should be sent as
MeilisearchCommunicationError
- Know errors like index is not found, or mistakes in the request like not-allowed params should be sent as
MeilisearchApiError
- Any other error should be a
MeilisearchError
Essentially all the error should extend from MeilisearchError
, the consumers should have a way to catch all the errors.
Let us know if this is not clear, or you have better idea!
TODO:
- Create a base error called
MeilisearchError
which will extend the standard error if it does not exist (when the language supports) - Make all the other errors extend this error.
- Move all errors without message to
MeilisearchCommunicationError
since it is not a Meilisearch error anyway.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers