GROOVY-8245: @newify(auto=false) not transforming declarations (closes groovy#571)

Author: jwagenleitner

src/main/org/codehaus/groovy/transform/NewifyASTTransformation.java

@@ -178,7 +178,7 @@ public Expression transform(Expression expr) {
             }
         } else if (expr instanceof DeclarationExpression) {
             DeclarationExpression de = (DeclarationExpression) expr;
-            if (de == candidate || auto) {
+            if (shouldTransform(de)) {
                 candidate = null;
                 Expression left = de.getLeftExpression();
                 Expression right = transform(de.getRightExpression());
@@ -191,6 +191,14 @@ public Expression transform(Expression expr) {
         return expr.transformExpression(this);
     }
 
+    private boolean shouldTransform(DeclarationExpression exp) {
+        return exp == candidate || auto || hasClassesToNewify();
+    }
+
+    private boolean hasClassesToNewify() {
+        return classesToNewify != null && !classesToNewify.getExpressions().isEmpty();
+    }
+
     private void newifyClass(ClassNode cNode, boolean autoFlag, ListExpression list) {
         String cName = cNode.getName();
         if (cNode.isInterface()) {

src/test/org/codehaus/groovy/transform/NewifyTransformTest.groovy

@@ -189,4 +189,26 @@ class NewifyTransformTest extends GroovyShellTestCase {
             assert !new Z().foo()
         '''
     }
+
+    // GROOVY-8245
+    void testDeclarationWhenAutoIsFalse() {
+        assertScript '''
+            class Foo {
+                static int answer = 7
+                Foo() {
+                    answer = 42
+                }
+            }
+            @Newify(auto=false, value=Foo)
+            class Bar {
+                static {
+                    Foo foo = Foo()
+                }
+                static void method() {}
+            }
+            assert Foo.answer == 7
+            Bar.method()
+            assert Foo.answer == 42
+        '''
+    }
 }