Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: _LOG_REQUEST_METRICS doesn't work #2896

Open
1 task
visch opened this issue Mar 5, 2025 · 1 comment
Open
1 task

bug: _LOG_REQUEST_METRICS doesn't work #2896

visch opened this issue Mar 5, 2025 · 1 comment
Assignees
@edgarrmondragon
Labels
flow::triage

Comments

@visch
Copy link
Contributor

visch commented Mar 5, 2025

Singer SDK Version

Latest

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Taps (catalog, state, etc.)

Operating System

No response

Description

If you set _LOG_REQUEST_METRICS

sdk/singer_sdk/streams/rest.py

Line 63 in d355d2e

_LOG_REQUEST_METRICS: bool = True
to False, Log's are still sent to stderr for Requests

Link to Slack/Linen

No response
@edgarrmondragon
Copy link
Collaborator

to False, Log's are still sent to stderr for Requests

Including request metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarrmondragon edgarrmondragon

Labels
flow::triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visch @edgarrmondragon