Skip to content

Commit b0303e8

Browse files
committed
fix: add fallback value
1 parent e91e483 commit b0303e8

File tree

3 files changed

+14
-24
lines changed

3 files changed

+14
-24
lines changed

packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery-design-properties.scss

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
//== Design Properties
55
//## Helper classes to change the look and feel of the component
66
========================================================================== */
7-
:root {
8-
--gallery-gap: var(--spacing-small, $dg-spacing-small);
9-
}
10-
117
// All borders
128
.widget-gallery-bordered-all {
139
.widget-gallery-item {
@@ -47,7 +43,7 @@
4743
left: 0;
4844
right: 0;
4945
border-bottom: 1px solid var(--grid-border-color, $grid-border-color);
50-
margin-top: calc(var(--gallery-gap) / 2 - 1px);
46+
margin-top: calc(var(--gallery-gap, var(--spacing-small, $spacing-small)) / 2 - 1px);
5147
}
5248
}
5349
}
@@ -73,34 +69,22 @@
7369

7470
// Grid spacing none
7571
.widget-gallery.widget-gallery-gridgap-none {
76-
.widget-gallery-items {
77-
--gallery-gap: 0px;
78-
gap: 0;
79-
}
72+
--gallery-gap: 0px;
8073
}
8174

8275
// Grid spacing small
8376
.widget-gallery.widget-gallery-gridgap-small {
84-
.widget-gallery-items {
85-
--gallery-gap: var(--spacing-small, $dg-spacing-small);
86-
gap: var(--spacing-small, $spacing-small);
87-
}
77+
--gallery-gap: var(--spacing-small, $spacing-small);
8878
}
8979

9080
// Grid spacing medium
9181
.widget-gallery.widget-gallery-gridgap-medium {
92-
.widget-gallery-items {
93-
--gallery-gap: var(--spacing-medium, $dg-spacing-medium);
94-
gap: var(--spacing-medium, $spacing-medium);
95-
}
82+
--gallery-gap: var(--spacing-medium, $spacing-medium);
9683
}
9784

9885
// Grid spacing large
9986
.widget-gallery.widget-gallery-gridgap-large {
100-
.widget-gallery-items {
101-
--gallery-gap: var(--spacing-large, $dg-spacing-large);
102-
gap: var(--spacing-large, $spacing-large);
103-
}
87+
--gallery-gap: var(--spacing-large, $spacing-large);
10488
}
10589

10690
// Pagination left
@@ -122,6 +106,7 @@
122106
}
123107

124108
.widget-gallery-disable-selected-items-highlight {
125-
// placeholder
126-
// this class in needed to disable standard styles of highlighted items
109+
// This class is needed to disable standard styles of highlighted items
110+
// Currently no specific styles need to be overridden
111+
/* stylelint-disable-line no-empty-rules */
127112
}

packages/modules/data-widgets/src/themesource/datawidgets/web/_gallery.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ $gallery-screen-md: $screen-md;
2323
}
2424

2525
.widget-gallery {
26+
--gallery-gap: var(--spacing-small, $gallery-gap);
27+
2628
.widget-gallery-items {
2729
display: grid;
28-
grid-gap: var(--spacing-small, $spacing-small);
30+
grid-gap: var(--gallery-gap);
2931

3032
/*
3133
Desktop widths

packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ $spacing-medium: 16px !default;
2929
$spacing-large: 24px !default;
3030
$spacing-larger: 32px !default;
3131

32+
// Gallery specific spacing
33+
$gallery-gap: $spacing-small !default;
34+
3235
// Effects and animations
3336
$dragging-color-effect: rgba(10, 19, 37, 0.8) !default;
3437
$skeleton-background: linear-gradient(90deg, rgba(194, 194, 194, 0.2) 0%, #d2d2d2 100%) !default;

0 commit comments

Comments
 (0)