Skip to content

Latest commit

 

History

History
104 lines (72 loc) · 5.07 KB

CODING_GUIDELINES.md

File metadata and controls

104 lines (72 loc) · 5.07 KB
Raw

Coding Guidelines

The Mercado Pago PHP SDK is a collaborative effort from the start. The SDK team thinks that contributions from different developer will enrich its feature set and make it more relevant to the community.

However, absorbing all contributions as-is, while expedient, might lead to difficulties in maintenance of the codebase is left unchecked. A collaborative codebase often establish guidelines for contributors to ensure code remains maintainable over time. The effort to maintain the SDK is no different in this regard, so a bit of guidance is in order.

The purpose of this guide is to set a baseline for contributions. These guidelines are not intended to limit the tools at your disposal nor to rewire the way you think but rather to encourage good neighbor behavior.

Language Guidelines

We use english language. This is to be consistent everywhere, and to be considerate with developers that do not speak our native language.

Therefore: source code, comments, documentation, commit messages, review comments, and any other kind of contribution * MUST* use english language.

Typos are unavoidable, but try to reduce them by using a spellchecker. Most IDEs can be configured to run one automatically.

Code Guidelines

To contribute to the project you need to have installed in your machine pre-commit tool to check the code style and formatting.

  1. To check if pre-commit is installed, you must run the command below successfully:
$ pre-commit --version
pre-commit 2.17.0
  1. After pre-commit is installed at your machine, inside the SDK project folder, you must run the command below to set up the git hook scripts of the project:
$ pre-commit install

After that, git hooks will run automatically before every commit command.

Generally speaking, be conscious when contributing and try following the same style that the code in the SDK already has. If you have any doubts, just ask us!

This rules will be enforced automatically when making a pull requests, and checks will fail if you do not follow them, resulting in your contribution being automatically rejected until fixed.

Comment Guidelines

Comments in code are a hard thing to write, not because the words are difficult to produce but because it is hard to make relevant comments. Too much of it and people do not read comments (and it obfuscates code reading) and too little of it gives you no recourse but to read large portions of codebase to get insight as to what a feature/codeblock is doing. Both situations are undesirable and efforts should be made at all time to have a please comment reading experience

As a general rule you would have to comment on decisions you made while coding that are not part of any specification.

In particular, you should always comment any decision that:

  • Departs from common wisdom or convention (The why's are necessary).
  • Takes a significant amount of time to produce. A good rule of thumb here is that if you spent more than 1 hour thinking on how to produce a fragment of code that took 2 minutes of wrist time to write you should document your thinking to aid reader and allow for validation.
  • Need to preserve properties of the implementation. This is the case of performance sensitive portions of the codebase, implementations of security primitives, congestion control algorithms, etc.

As a general rule of what not to comment you should avoid:

  • Commenting on structure of programs that is already part of a convention, specified or otherwise.
  • Having pedantic explanations of behavior that can be found by immediate examination of the surrounding code artifacts.
  • Commenting on behavior you cannot attest.

Branching Guidelines

Currently master is our only long term branch, below a few suggestions of short term branches naming:

  • hotfix/something-needs-fix: Small routine patches in code to feature already there.
  • feature/something-new: A new feature or a change in an existent feature. Beware of breaking changes that would require a major version bump.
  • doc/improves-documentation-for-this-feature: If you add or change documentation with no impact to the source code.

Git Guidelines

All commits SHOULD follow the seven rules of a great Git commit message:

  1. Separate subject from body with a blank line.
  2. Limit the subject line to 72 characters.
  3. Capitalize the subject line.
  4. Do not end the subject line with a period.
  5. Use the imperative mood in the subject line.
  6. Wrap the body at 72 characters.
  7. Use the body to explain what and why vs. how.

Commits such as "fix tests", "now it's working", and many other common messages we find usually in code WON'T be accepted.

Ideally we would like to enforce these rules, but we are realistic and understand that it might be a big change for some people. So unless deviating heavily from what was stated we might accept your commits even if not following these rules perfectly.

Please avoid taking too much time to deliver code, and always rebase your code to avoid reverse merge commits.