Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comparison tool #35

Closed
andlaus opened this issue Mar 16, 2022 · 6 comments
Closed

add comparison tool #35

andlaus opened this issue Mar 16, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request good first contribution Good for newcomers nice to have Things which improve the quality of life but are not a matter of life and death.

Comments

@andlaus
Copy link
Collaborator

andlaus commented Mar 16, 2022

having a tool which compares two ECU versions and/or complete databases would be nice. something along the lines of:

# compare ECUs
odxtools compare PDX_FILE.pdx somersault_lazy somersault_assiduous

# compare complete files
odxtools compare PDX_FILE_OLD.pdx PDX_FILE_NEW.pdx

Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information

@andlaus andlaus added enhancement New feature or request good first contribution Good for newcomers nice to have Things which improve the quality of life but are not a matter of life and death. labels Mar 16, 2022
@KarloGaloz
Copy link

Hi Andreas,

I'm checking out the project rn and I'm interested in adding the feature.
You can assign me to this issue if you like.

@andlaus
Copy link
Collaborator Author

andlaus commented Sep 16, 2023

From my side, that is not really required (just open a PR once there's something to show), but I'm happy to put you under a bit of pressure if you want to work on this ;)

@KarloGaloz
Copy link

Awesome - will do :)

@kakoeh kakoeh mentioned this issue Dec 15, 2023
@kakoeh
Copy link
Contributor

kakoeh commented Jan 5, 2024

PR #249 introduced compare as new command line utility.
The compare subcommand can be used to compare databases (pdx-files) and diagnostic layers with each other. All diagnostic services as well as its parameters of specified databases and variants are compared with each other and changes are displayed.

Examples:
Comparison of two ecu versions:
odxtools compare ./path/to/database.pdx -v variant1 variant2
Comparison of two database versions:
odxtools compare ./path/to/database.pdx -db ./path/to/old-database.pdx

Katja Köhler <[email protected]>, on behalf of MBition GmbH.
Provider Information

@kakoeh
Copy link
Contributor

kakoeh commented Jan 5, 2024

Ideas for improvement of comparison tool: #252

@andlaus
Copy link
Collaborator Author

andlaus commented Jan 8, 2024

this issue has been completed via #249. closing...

@andlaus andlaus closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first contribution Good for newcomers nice to have Things which improve the quality of life but are not a matter of life and death.
Projects
None yet
Development

No branches or pull requests

3 participants