Skip to content

Conversation

@mdecourcy
Copy link
Collaborator

@mdecourcy mdecourcy commented Nov 29, 2025

Closes #3830

Paths also touched are via admin access.

image

@github-actions github-actions bot added the enhancement New feature or request label Nov 29, 2025
Copy link
Collaborator

@DaneEvans DaneEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. merge for the next internal

@jamesarich jamesarich added this pull request to the merge queue Nov 30, 2025
Merged via the queue into meshtastic:main with commit e18f72d Nov 30, 2025
5 checks passed
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.53%. Comparing base (d83c83c) to head (19d7602).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ings/radio/component/ShutdownConfirmationDialog.kt 0.00% 40 Missing ⚠️
...g/meshtastic/feature/settings/radio/RadioConfig.kt 0.00% 25 Missing ⚠️
...e/settings/radio/component/DeviceConfigItemList.kt 0.00% 2 Missing ⚠️
.../org/meshtastic/feature/settings/SettingsScreen.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3858      +/-   ##
========================================
- Coverage   0.53%   0.53%   -0.01%     
========================================
  Files        390     391       +1     
  Lines      22846   22901      +55     
  Branches    2889    2896       +7     
========================================
  Hits         122     122              
- Misses     22703   22758      +55     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add node name on the shutdown confirmation popup

3 participants