Skip to content

meson setup --reconfigure errors when setting base options #14615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnicolodi opened this issue May 17, 2025 · 4 comments · Fixed by #14624
Closed

meson setup --reconfigure errors when setting base options #14615

dnicolodi opened this issue May 17, 2025 · 4 comments · Fixed by #14624
Labels
regression
Milestone
1.8.1

Comments

@dnicolodi
Copy link
Member

dnicolodi commented May 17, 2025 •
edited
Loading 

$ meson --version
1.8.99
$ cat meson.build
project('foo')
$ meson setup build
The Meson build system
Version: 1.8.99
Source dir: /private/tmp/meson-test
Build dir: /private/tmp/meson-test/build
Build type: native build
Project name: foo
Project version: undefined
Host machine cpu family: x86_64
Host machine cpu: x86_64
Build targets in project: 0

Found ninja-1.12.1 at /usr/local/bin/ninja
$ meson setup build --reconfigure -Db_ndebug=if-release

ERROR: Unknown options: ":b_ndebug" not found.

This used to work up to meson 1.8.0 and is a regression in git main.
@dnicolodi dnicolodi mentioned this issue May 17, 2025
Merged
@eli-schwartz
Copy link
Member

I can't reproduce this, tried with commit c443154 and the 1.8.0 tag.

There's a pending fix (merged in git master) that causes reconfigure to stop being ignored entirely.

@bonzini
Copy link
Collaborator

bonzini commented May 18, 2025 •
edited
Loading

This might be a regression in 1.8.1, if so it has to be fixed before the release... I am going to check and post a fix today or tomorrow.

@eli-schwartz
Copy link
Member

Aha, it only occurs without a language defined.

2f6fc30df10583c77dc1318f2fb62111de3e121c is the first bad commit
commit 2f6fc30df10583c77dc1318f2fb62111de3e121c (HEAD, refs/bisect/bad)
Author:     Paolo Bonzini <[email protected]>
AuthorDate: Fri May 9 05:54:09 2025
Commit:     Eli Schwartz <[email protected]>
CommitDate: Thu May 15 02:05:18 2025

    msetup: update coredata if options are passed together with --reconfigure
    
    This makes "meson setup --reconfigure" behave quite literally the same as
    "meson configure" + "meson setup"; except that saving coredata and
    cmdline file is delayed until the setup succeeds.
    
    Fixes: #14575
    Signed-off-by: Paolo Bonzini <[email protected]>

 mesonbuild/msetup.py | 3 +++
 1 file changed, 3 insertions(+)

"broken" by actually processing options at all.

@eli-schwartz eli-schwartz added this to the 1.8.1 milestone May 18, 2025
@bonzini
Copy link
Collaborator

bonzini commented May 18, 2025

Yes, it's the reconfigure version of #14255.

@bonzini bonzini mentioned this issue May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Make configuration accept unknown-but-maybe-valid-in-the-future options bonzini/meson
3 participants
@bonzini @dnicolodi @eli-schwartz