Merge pull request #66 from atoomic/tpc23

Multiple changes during PTS 23

Author: oalders

.perlcriticrc

@@ -11,13 +11,19 @@ verbose = 11
 [-RegularExpressions::RequireExtendedFormatting]
 [-RegularExpressions::RequireLineBoundaryMatching]
 [-Subroutines::ProhibitExplicitReturnUndef]
+[-Subroutines::ProhibitSubroutinePrototypes]
 [-ValuesAndExpressions::ProhibitNoisyQuotes]
 [-ValuesAndExpressions::ProhibitAccessOfPrivateData]
 [-Variables::ProhibitPunctuationVars]
 
 [CodeLayout::RequireTrailingCommas]
 severity = 4
 
+# Don't use function prototypes
+[Community::Prototypes]
+severity = 4
+signature_enablers = cPstrict GrepCpan::std
+
 [TestingAndDebugging::RequireUseStrict]
 equivalent_modules = MetaCPAN::Moose Mojo::Base Test::Routine
 

.tidyallrc

@@ -5,6 +5,7 @@ select = bin/app.psgi
 select = cpanfile
 ignore = t/var/**/*
 ignore = .gitignore
+ignore = cpanfile
 argv = --profile=$ROOT/.perltidyrc
 
 [PerlCritic]

Makefile.PL

@@ -12,7 +12,7 @@ WriteMakefile(
     AUTHOR           => q{Nicolas R. <[email protected]>},
     VERSION_FROM     => 'lib/grepcpan.pm',
     ABSTRACT         => 'grep metacpan web frontend',
-    MIN_PERL_VERSION => 5.022,
+    MIN_PERL_VERSION => 5.036,
     (
         $eumm_version >= 6.3001
         ? ( 'LICENSE' => 'perl' )

README.md

@@ -15,15 +15,16 @@ but it should be pretty straight forward to setup a development environment and
 ## Requirements
 
 * a git client (should be compiled with libpcre)
-* perl 5.22 or later (5.22 is the recommended version, consider [using perlbrew](https://perlbrew.pl))
+* perl 5.36 or later (5.36 is the recommended version, consider [using perlbrew](https://perlbrew.pl))
 * App::cpanminus (read manual on [metacpan](https://metacpan.org/pod/App::cpanminus) )
 
 ### git with pcre support
 
 For macOS users, it's recommended to use [homebrew](https://brew.sh) to install git with pcre support
 
 	> brew install pcre
-	> brew reinstall --with-pcre git
+	> export USE_LIBPCRE=yes
+	> brew reinstall --build-from-source git
 
 You can check if git support pcre by using the '-P' option
 
@@ -32,7 +33,7 @@ You can check if git support pcre by using the '-P' option
 
 ## Cloning repositories
 
-You should start forking the main (metacpan-grep-front-end repository)[https://github.com/metacpan/metacpan-grep-front-end]
+You should start forking the main [metacpan-grep-front-end repository](https://github.com/metacpan/metacpan-grep-front-end)
 You can then clone it locally (where you should replace ~YOUR-GITHUB-USERNAME~ by your github username )
 
 	> git clone [email protected]:~YOUR-GITHUB-USERNAME~/metacpan-grep-front-end.git
@@ -41,14 +42,14 @@ You can then clone it locally (where you should replace ~YOUR-GITHUB-USERNAME~ b
 
 The frontend is not using a database, but a `git repo` itself as a backend.
 For this the production is using one huge git repository (~20 Go) indexing all the CPAN in one place !
-You can read more on this topic and find tools used to build this Git repo on the (GitHub Repos)[https://grep.metacpan.org/source-code] page.
+You can read more on this topic and find tools used to build this Git repo on the [GitHub Repos](https://grep.metacpan.org/source-code) page.
 
 We do not want to use such a beast during development cycles, we only need a smaller version of it,
-you can simply clone it from this (metacpan-cpan-extracted-lite)[https://github.com/metacpan/metacpan-cpan-extracted-lite].
+you can simply clone it from this [metacpan-cpan-extracted-lite](https://github.com/metacpan/metacpan-cpan-extracted-lite).
 It should be clone at the same level of *metacpan-grep-front-end* itself (do not clone it inside the repository).
 
 	# clone at the same level of metacpan-grep-front-end
-	# cd ..; # if you are in metacpan-grep-front-end repo
+	# cd .. # if you are in metacpan-grep-front-end repo
 	> git clone https://github.com/metacpan/metacpan-cpan-extracted-lite.git
 
 	# you should have something like this
@@ -59,7 +60,7 @@ It should be clone at the same level of *metacpan-grep-front-end* itself (do not
 
 Now that you have the repository set, let's install all the perl modules required.
 
-You can check your perl version. ( 5.022001 is the recommended one for now )
+You can check your perl version. ( 5.036000 is the recommended one for now )
 
 	perl -E 'say $]'
 
@@ -120,7 +121,7 @@ From there you should be ready to
 
 The project comes with a basic `.travis.yml` file.
 
-If you want to start smoking your own branches, you simply need to link your [GitHub account](https://github.com)
-to your (Travis CI account)[https://travis-ci.org/], then enable the repository in your (Travis Dashboard)[https://travis-ci.org/dashboard]
+If you want to start smoking your own branches, you simply need to link your [GitHub account](https://github.com/)
+to your [Travis CI account](https://travis-ci.org/), then enable the repository in your [Travis Dashboard](https://travis-ci.org/dashboard)
 
 Note that any Pull Request submitted via GitHub would trigger a Travis smoke without any settings required from your side :-)

config.yml

@@ -75,5 +75,5 @@ grepcpan:
       git: '/home/atoomic/bin/git'
    cache:
       directory: '~APPDIR~/var/tmp'
-      version: '1.14'
+      version: '2.02'
 

cpanfile

@@ -2,7 +2,6 @@ requires "Git::Repository"             => 0;
 requires "Gazelle"                     => 0;
 requires "Proc::ProcessTable"          => 0;
 requires "Digest::MD5"                 => 0;
-requires "YAML::Syck"                  => 0;
 requires "Simple::Accessor"            => "1.02";
 requires "Time::HiRes"                 => 0;
 requires "Test::Harness"               => 0;
@@ -19,6 +18,9 @@ requires "FindBin"                     => 0;
 requires "Cpanel::JSON::XS"            => 0;
 requires "JSON::MaybeXS"               => 0;
 requires "HTTP::Entity::Parser"        => 0;
+requires "Sereal"                      => 0;
+requires "Sereal::Encoder"             => 0;
+requires "Sereal::Decoder"             => 0;
 
 recommends "YAML"             => "0";
 recommends "URL::Encode::XS"  => "0";
@@ -40,6 +42,9 @@ on "test" => sub {
 on 'develop' => sub {
     recommends 'Devel::NYTProf';
     recommends "Code::TidyAll::Git::Precommit";
+    recommends "Code::TidyAll::Plugin::UniqueLines";
+    recommends "Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText";
     recommends "Perl::Critic::Nits";
+    recommends "Perl::Critic::Policy::Community::Prototypes";
 };