Change definition of APPDIR

Author: atoomic

.perlcriticrc

@@ -11,13 +11,19 @@ verbose = 11
 [-RegularExpressions::RequireExtendedFormatting]
 [-RegularExpressions::RequireLineBoundaryMatching]
 [-Subroutines::ProhibitExplicitReturnUndef]
+[-Subroutines::ProhibitSubroutinePrototypes]
 [-ValuesAndExpressions::ProhibitNoisyQuotes]
 [-ValuesAndExpressions::ProhibitAccessOfPrivateData]
 [-Variables::ProhibitPunctuationVars]
 
 [CodeLayout::RequireTrailingCommas]
 severity = 4
 
+# Don't use function prototypes
+[Community::Prototypes]
+severity = 4
+signature_enablers = cPstrict GrepCpan::std
+
 [TestingAndDebugging::RequireUseStrict]
 equivalent_modules = MetaCPAN::Moose Mojo::Base Test::Routine
 

.tidyallrc

@@ -5,6 +5,7 @@ select = bin/app.psgi
 select = cpanfile
 ignore = t/var/**/*
 ignore = .gitignore
+ignore = cpanfile
 argv = --profile=$ROOT/.perltidyrc
 
 [PerlCritic]

cpanfile

@@ -41,6 +41,8 @@ on 'develop' => sub {
     recommends 'Devel::NYTProf';
     recommends "Code::TidyAll::Git::Precommit";
     recommends "Code::TidyAll::Plugin::UniqueLines";
+    recommends "Perl::Critic::Policy::Documentation::RequirePodLinksIncludeText";
     recommends "Perl::Critic::Nits";
+    recommends "Perl::Critic::Policy::Community::Prototypes";
 };
 

environments/development.yml

@@ -25,7 +25,7 @@ startup_info: 1
 grepcpan:
    nocache: 0
    maxworkers: 2
-   gitrepo: '~APPDIR~/../../metacpan-cpan-extracted-lite'
+   gitrepo: '~APPDIR~/../metacpan-cpan-extracted-lite'
    #gitrepo: '/shared/metacpan_git'
    binaries:
       git: '/opt/homebrew/bin/git' # for macOS

environments/unit-tests.yml

@@ -25,7 +25,7 @@ startup_info: 1
 grepcpan:
    nocache: 0
    maxworkers: 2
-   gitrepo: '~APPDIR~/../../metacpan-cpan-extracted-lite'
+   gitrepo: '~APPDIR~/../metacpan-cpan-extracted-lite'
 #   binaries:
 #      git: '/usr/local/cpanel/3rdparty/bin/git'
    cache:

lib/GrepCpan/Grep.pm

@@ -188,11 +188,13 @@ sub cache_cleanup {    # aka tmpwatch
     return;
 }
 
-sub massage_path {
-    my ( $self, $s ) = @_;
+sub massage_path ( $self, $s ) {
 
     return unless defined $s;
+
     my $appdir = $self->root;
+    $appdir =~ s{/(?:bin|t)/?$}{};
+
     $s =~ s{~APPDIR~}{$appdir}g;
 
     return $s;

t/GrepCpan-Grep-dosearch.t

@@ -50,7 +50,7 @@ my $config = {
         'history_size' => '20'
     },
     'demo'    => '0',
-    'gitrepo' => '~APPDIR~/../../metacpan-cpan-extracted-lite',
+    'gitrepo' => '~APPDIR~/../metacpan-cpan-extracted-lite',
     'limit'   => {
         'distros_per_page'      => '30',
         'files_git_run_bg'      => '2000',

t/GrepCpan-Grep-workers.t

@@ -12,13 +12,13 @@ use GrepCpan::Grep;
 
 use File::Temp ();
 
-my $tmp = File::Temp->newdir( "grep-XXXXXX", DIR => q[/tmp], UNLINK => 1 );
+my $tmp    = File::Temp->newdir( "grep-XXXXXX", DIR => q[/tmp], UNLINK => 1 );
 my $tmpdir = $tmp->dirname;
 ok -d $tmpdir, "using tmp directory: $tmpdir";
 
 my $config = {
     'maxworkers' => '2',
-    'gitrepo'    => '~APPDIR~/../../metacpan-cpan-extracted-lite',
+    'gitrepo'    => '~APPDIR~/../metacpan-cpan-extracted-lite',
     'cache'      => {
         'directory' => $tmpdir,
         'version'   => "0.$$"
@@ -59,7 +59,7 @@ my $fork_a_worker = sub {
                                              # the worker is working....
         while ( kill USR2 => $mainpid )
         {    # run until as long as our parent is running
-                #note "sending USR2 from $$";
+             #note "sending USR2 from $$";
             sleep 1;
         }
         exit;
@@ -75,7 +75,7 @@ is $grep->check_if_a_worker_is_available(), undef,
 
 kill 'KILL' => $kids[0];
 ok waitpid( $kids[0], 0 ), 'one worker finished';
-ok $fork_a_worker->(), 'can fork an extra worker';
+ok $fork_a_worker->(),     'can fork an extra worker';
 is $grep->check_if_a_worker_is_available(), undef,
     "queue is full: cannot start an extra worker";
 

t/GrepCpan-Grep.t

@@ -23,15 +23,15 @@ my $test_methods = {
 my $config = {
     'binaries' => { 'git' => '/home/atoomic/bin/git' },
     'cache'    => {
-        'directory' => '~APPDIR~/../var/tmp',
+        'directory' => '~APPDIR~/var/tmp',
         'version'   => '1.03'
     },
     'cookie' => {
         'history_name' => 'lastsearch',
         'history_size' => '20'
     },
     'demo'    => '0',
-    'gitrepo' => '~APPDIR~/../../metacpan-cpan-extracted-lite',
+    'gitrepo' => '~APPDIR~/../metacpan-cpan-extracted-lite',
     'limit'   => {
         'distros_per_page'      => '30',
         'files_git_run_bg'      => '2000',
@@ -48,7 +48,7 @@ my $config = {
     }
 };
 
-$grepcpan::VERSION = '1.00_01'; # devel version
+$grepcpan::VERSION = '1.00_01';    # devel version
 
 my $grep = GrepCpan::Grep->new( config => $config );
 isa_ok $grep, 'GrepCpan::Grep';
@@ -80,13 +80,14 @@ like $grep->current_version,
             [ 'distros/e', 'eBay-API', 'eg/XML/getSearchResults.pl' ],
         'distros/f/failures/lib/failures.pm' =>
             [ 'distros/f', 'failures', 'lib/failures.pm' ],
-        'distros/f/fewer/Changes' => [ 'distros/f', 'fewer', 'Changes' ],
+        'distros/f/fewer/Changes'    => [ 'distros/f', 'fewer', 'Changes' ],
         'distros/s/snapcast/LICENSE' =>
             [ 'distros/s', 'snapcast', 'LICENSE' ],
     };
 
     foreach my $input ( sort keys %$valid_input ) {
-        is [ GrepCpan::Grep::massage_filepath($input) ] => $valid_input->{$input},
+        is [ GrepCpan::Grep::massage_filepath($input) ] =>
+            $valid_input->{$input},
             "massage_filepath($input)";
     }