Result of resolveArguments() is unused in ICUMessageSourceSupport

[eneveu]

In ICUMessageSourceSupport, I'm wondering if we should do

    synchronized (messageFormat) {
        return resolveArguments(args, locale).formatWith(messageFormat);
    }

instead of:

    resolveArguments(args, locale);
    synchronized (messageFormat) {
        return args.formatWith(messageFormat);
    }

That's what they do in the Spring MessageSourceSupport, and I don't understand what resolveArguments() does if we don't use the result?

spring-icu/src/main/java/com/devtrigger/grails/icu/ICUMessageSourceSupport.java

Lines 120 to 123 in 2ed6735

	resolveArguments(args, locale);
	synchronized (messageFormat) {
	return args.formatWith(messageFormat);
	}

https://github.com/spring-projects/spring-framework/blob/00d2606b000f9bdafbd7f4a16b6599fb51b53fa4/spring-context/src/main/java/org/springframework/context/support/MessageSourceSupport.java#L147-L149

[meticoeus]

I'm not exactly sure. I converted this from a Grails plugin I was using on a previous project so that it would work with just Spring. Most of the files in the project have not been modified, including this one.

I will take a look to see exactly what that would change. It does look strange.

[meticoeus]

It seems like the code was originally based on/copied from the Spring project.

Here is the commit where it was changed from what Spring does to the current implementation. There isn't much detail given as to why it changed.

It appears the args are not mutated by the method so it seems to be throwing away the result.