[IMP] l10n_id_efaktur_coretax: Update VAT calculation and add restriction

Update the VAT calculation inside the E-faktur XML based on tax group
added validation to prevent inproper tax combination

task-4948267

closes odoo#236625

Signed-off-by: Nicolas Viseur (vin) <[email protected]>
Signed-off-by: Kaleb Juliu (kaju) <[email protected]>

Author: kaju-odoo

addons/l10n_id_efaktur/models/account_move.py

@@ -83,17 +83,6 @@ def _compute_show_kode_transaksi(self):
                 and move.country_code == 'ID'
             )
 
-    @api.constrains('l10n_id_kode_transaksi', 'line_ids', 'partner_id')
-    def _constraint_kode_ppn(self):
-        ppn_tag = self.env.ref('l10n_id.ppn_tag')
-        for move in self.filtered(lambda m: m.l10n_id_need_kode_transaksi and m.l10n_id_kode_transaksi != '08'):
-            if any(ppn_tag.id in line.tax_tag_ids.ids for line in move.line_ids if line.display_type == 'product') \
-                    and any(ppn_tag.id not in line.tax_tag_ids.ids for line in move.line_ids if line.display_type == 'product'):
-                raise UserError(_('Cannot mix VAT subject and Non-VAT subject items in the same invoice with this kode transaksi.'))
-        for move in self.filtered(lambda m: m.l10n_id_need_kode_transaksi and m.l10n_id_kode_transaksi == '08'):
-            if any(ppn_tag.id in line.tax_tag_ids.ids for line in move.line_ids if line.display_type == 'product'):
-                raise UserError('Kode transaksi 08 is only for non VAT subject items.')
-
     @api.constrains('l10n_id_tax_number')
     def _constrains_l10n_id_tax_number(self):
         for record in self.filtered('l10n_id_tax_number'):

addons/l10n_id_efaktur_coretax/i18n/l10n_id_efaktur_coretax.pot

@@ -4,10 +4,10 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 18.0\n"
+"Project-Id-Version: Odoo Server 17.0+e\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-11-03 15:43+0000\n"
-"PO-Revision-Date: 2025-11-03 15:43+0000\n"
+"POT-Creation-Date: 2025-11-17 07:58+0000\n"
+"PO-Revision-Date: 2025-11-17 07:58+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -700,6 +700,57 @@ msgstr ""
 #: model:ir.model.fields,field_description:l10n_id_efaktur_coretax.field_res_partner__l10n_id_kode_transaksi
 #: model:ir.model.fields,field_description:l10n_id_efaktur_coretax.field_res_users__l10n_id_kode_transaksi
 msgid "Invoice Transaction Code"
+
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+#, python-format
+msgid "Invoice %s: can only have one STLG group."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+#, python-format
+msgid "Invoice %s: can only have one tax group (excluding STLG)."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+msgid ""
+"Invoice %(inv)s: line '%(line)s' contains both Luxury-Goods and Non-Luxury-"
+"Goods taxes."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+msgid ""
+"Invoice %(inv)s: line '%(line)s' contains both Non-Luxury-Goods and STLG "
+"taxes."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+msgid ""
+"Invoice %(inv)s: line '%(line)s' has STLG tax but missing the required "
+"Luxury-Goods tax."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+msgid ""
+"Invoice %(inv)s: transaction code %(kode)s does not allow 0%% (Zero-rated or"
+" Exempt) taxes."
+msgstr ""
+
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
+msgid ""
+"Invoice %(inv)s: transaction code %(kode)s must always have tax amount 0%%."
 msgstr ""
 
 #. module: l10n_id_efaktur_coretax
@@ -871,6 +922,13 @@ msgstr ""
 msgid "Passport"
 msgstr ""
 
+#. module: l10n_id_efaktur_coretax
+#. odoo-python
+#: code:addons/l10n_id_efaktur_coretax/models/account_move_line.py:0
+#, python-format
+msgid "Price for line '%s' cannot be a negative amount. Please check again."
+msgstr ""
+
 #. module: l10n_id_efaktur_coretax
 #: model:ir.model,name:l10n_id_efaktur_coretax.model_product_template
 msgid "Product"
@@ -1001,7 +1059,8 @@ msgstr ""
 #. module: l10n_id_efaktur_coretax
 #. odoo-python
 #: code:addons/l10n_id_efaktur_coretax/models/account_move.py:0
-msgid "Unable to download E-faktur fot he following reasons(s):"
+#, python-format
+msgid "Unable to download E-faktur for the following reason(s):"
 msgstr ""
 
 #. module: l10n_id_efaktur_coretax

addons/l10n_id_efaktur_coretax/models/account_move.py

@@ -185,6 +185,66 @@ def _compute_l10n_id_coretax_add_info(self):
                 if digits:
                     move.l10n_id_coretax_add_info_08 = f"TD.005{digits[-2:]}"
 
+    def _validate_tax_groups(self):
+        err_messages = []
+        allowed_codes = {'01', '02', '03', '04', '05', '06', '09', '10'}
+        must_be_zero_codes = {'07', '08'}
+
+        for move in self:
+            kode = move.l10n_id_kode_transaksi
+            non_luxury_group = self.env['account.chart.template'].with_company(move.company_id.id).ref("l10n_id_tax_group_non_luxury_goods", raise_if_not_found=False)
+            luxury_group = self.env['account.chart.template'].with_company(move.company_id.id).ref("l10n_id_tax_group_luxury_goods", raise_if_not_found=False)
+            zero_group = self.env['account.chart.template'].with_company(move.company_id.id).ref("l10n_id_tax_group_0", raise_if_not_found=False)
+            exempt_group = self.env['account.chart.template'].with_company(move.company_id.id).ref("l10n_id_tax_group_exempt", raise_if_not_found=False)
+            stlg_group = self.env['account.chart.template'].with_company(move.company_id.id).ref("l10n_id_tax_group_stlg", raise_if_not_found=False)
+            product_lines = move.line_ids.filtered(lambda line: line.display_type == 'product')
+            all_taxes = product_lines.mapped('tax_ids')
+            tax_groups = set(all_taxes.mapped('tax_group_id'))
+
+            # Multiple tax groups check
+            if len([g for g in tax_groups if g not in {stlg_group}]) > 1:
+                err_messages.append(_("Invoice %s: can only have one tax group (excluding STLG).", move.name or ''))
+            if len([g for g in tax_groups if g == stlg_group]) > 1:
+                err_messages.append(_("Invoice %s: can only have one STLG group.", move.name or ''))
+
+            # Allowed codes (01-06, 09, 10)
+            if kode in allowed_codes:
+                for line in product_lines:
+                    line_tax_groups = set(line.tax_ids.mapped('tax_group_id'))
+                    if luxury_group and non_luxury_group and {luxury_group, non_luxury_group}.issubset(line_tax_groups):
+                        err_messages.append(_(
+                            "Invoice %(inv)s: line '%(line)s' contains both Luxury-Goods and Non-Luxury-Goods taxes.",
+                            inv=move.name or '', line=line.product_id.display_name or '')
+                        )
+                    if non_luxury_group and stlg_group and {non_luxury_group, stlg_group}.issubset(line_tax_groups):
+                        err_messages.append(_(
+                            "Invoice %(inv)s: line '%(line)s' contains both Non-Luxury-Goods and STLG taxes.",
+                            inv=move.name or '', line=line.product_id.display_name or '')
+                        )
+                    if stlg_group and stlg_group in line_tax_groups:
+                        if not (luxury_group and luxury_group in line_tax_groups):
+                            err_messages.append(_(
+                                "Invoice %(inv)s: line '%(line)s' has STLG tax but missing the required Luxury-Goods tax.",
+                                inv=move.name or '', line=line.product_id.display_name or '')
+                            )
+                    for tax in line.tax_ids:
+                        if ((hasattr(tax, 'amount') and float(tax.amount) == 0.0) or (tax.tax_group_id in {zero_group, exempt_group})):
+                            err_messages.append(_(
+                                "Invoice %(inv)s: transaction code %(kode)s does not allow 0%% (Zero-rated or Exempt) taxes.",
+                                inv=move.name or '', kode=kode)
+                            )
+
+            # Must-be-zero codes (07-08)
+            elif kode in must_be_zero_codes:
+                for line in product_lines:
+                    for tax in line.tax_ids:
+                        if hasattr(tax, 'amount') and float(tax.amount) != 0.0:
+                            err_messages.append(_(
+                                "Invoice %(inv)s: transaction code %(kode)s must always have tax amount 0%%.",
+                                inv=move.name or '', kode=kode)
+                            )
+        return err_messages
+
     def download_efaktur(self):
         """OVERRIDE l10n_id_efaktur
 
@@ -232,8 +292,11 @@ def download_efaktur(self):
                 if not (record.l10n_id_coretax_add_info_08 and record.l10n_id_coretax_facility_info_08):
                     err_messages.append(_("Invoice %s doesn't contain the Additional info and Facility Stamp yet (Kode 08)", record.name))
 
+        # Check tax groups
+        err_messages.extend(self._validate_tax_groups())
+
         if err_messages:
-            err_messages = [_('Unable to download E-faktur fot he following reasons(s):')] + err_messages
+            err_messages = [_('Unable to download E-faktur for the following reason(s):')] + err_messages
             raise ValidationError('\n - '.join(err_messages))
 
         # All invoices in self have no documents; we can create a new one for them.

addons/l10n_id_efaktur_coretax/models/account_move_line.py

@@ -1,7 +1,8 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
-from odoo import models
-from odoo.tools.float_utils import float_repr
+from odoo import _, models
+from odoo.tools.float_utils import float_repr, float_compare
+from odoo.exceptions import ValidationError
 
 
 class AccountMoveLine(models.Model):
@@ -12,6 +13,9 @@ def _l10n_id_coretax_build_invoice_line_vals(self, vals):
         self.ensure_one()
         idr = self.env.ref('base.IDR')
 
+        if float_compare(self.price_subtotal, 0.0, precision_rounding=self.currency_id.rounding) < 0:
+            raise ValidationError(_("Price for line '%s' cannot be a negative amount. Please check again.", self.name))
+
         # initialize
         if not vals.get('lines'):
             vals['lines'] = []
@@ -21,8 +25,15 @@ def _l10n_id_coretax_build_invoice_line_vals(self, vals):
         # Separate tax into the regular and luxury component
         ChartTemplate = self.env['account.chart.template'].with_company(self.company_id)
         luxury_tax_group = ChartTemplate.ref('l10n_id_tax_group_luxury_goods', raise_if_not_found=False)
+        stlg_tax_group = ChartTemplate.ref('l10n_id_tax_group_stlg', raise_if_not_found=False)
+        zero_tax_group_0 = ChartTemplate.ref('l10n_id_tax_group_0', raise_if_not_found=False)
+        zero_tax_group_exempt = ChartTemplate.ref('l10n_id_tax_group_exempt', raise_if_not_found=False)
+        zero_tax_groups = {zero_tax_group_0, zero_tax_group_exempt} - {False}
+
+        zero_tax = self.tax_ids.filtered(lambda tax: tax.tax_group_id in zero_tax_groups)
         luxury_tax = self.tax_ids.filtered(lambda tax: tax.tax_group_id == luxury_tax_group)
-        regular_tax = self.tax_ids - luxury_tax
+        stlg_tax = self.tax_ids.filtered(lambda tax: tax.tax_group_id == stlg_tax_group)
+        regular_tax = self.tax_ids - luxury_tax - stlg_tax - zero_tax
 
         # "Price" is unit price calculation excluding tax and discount
         # "TotalDiscount" is total of "Price" * quantity * discount
@@ -38,23 +49,15 @@ def _l10n_id_coretax_build_invoice_line_vals(self, vals):
             "TotalDiscount": idr.round(self.discount * tax_res['total_excluded'] * self.quantity / 100),
             "TaxBase": idr.round(self.price_subtotal),  # DPP
             "VATRate": 12,
-            "STLGRate": sum(luxury_tax.mapped('amount')) if luxury_tax else 0.0,
+            "STLGRate": stlg_tax.amount if stlg_tax else 0.0,
         }
-
-        # Code 04 represents "Using other value as tax base". This code is now the norm
-        # being used if user is selling non-luxury item where we have to multiply original price
-        # by ratio of 11/12 and having VATRate of 12 resulting to effectively 11% tax.
-        if self.move_id.l10n_id_kode_transaksi == "04":
-            line_val['VATRate'] = 12
-            line_val['OtherTaxBase'] = idr.round(self.price_subtotal * 11 / 12)
-        # For all other code, OtherTaxBase will follow TaxBase and calculation of VAT should follow the amount of tax itself
-        else:
-            line_val['VATRate'] = sum(regular_tax.mapped('amount'))
+        if self.move_id.l10n_id_kode_transaksi == "01" or (not regular_tax and not zero_tax):
             line_val['OtherTaxBase'] = line_val['TaxBase']
+        else:
+            line_val['OtherTaxBase'] = idr.round(self.price_subtotal * 11 / 12)
 
         line_val['VAT'] = idr.round(line_val['OtherTaxBase'] * line_val['VATRate'] / 100)
         line_val['STLG'] = idr.round(line_val['STLGRate'] * line_val['OtherTaxBase'] / 100)
-
         # for numerical attributes in line_val, use float_repr to ensure proper formatting
         numerical_fields = ['Price', 'TotalDiscount', 'TaxBase', 'OtherTaxBase', 'VAT', 'STLG']
         for field in numerical_fields: